* [PATCH] auxdisplay: remove PARPORT dependency @ 2009-02-07 0:06 hartleys 2009-02-09 22:37 ` Andrew Morton 0 siblings, 1 reply; 5+ messages in thread From: hartleys @ 2009-02-07 0:06 UTC (permalink / raw) To: lkml Remove PARPORT dependency for Auxiliary Display support. This is not needed since the dependency for the KS0108 driver is PARPORT_PC. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> --- diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig index 14b9d5f..c07e725 100644 --- a/drivers/auxdisplay/Kconfig +++ b/drivers/auxdisplay/Kconfig @@ -6,7 +6,6 @@ # menuconfig AUXDISPLAY - depends on PARPORT bool "Auxiliary Display support" ---help--- Say Y here to get to see options for auxiliary display drivers. @@ -14,7 +13,7 @@ menuconfig AUXDISPLAY If you say N, all options in this submenu will be skipped and disabled. -if AUXDISPLAY && PARPORT +if AUXDISPLAY config KS0108 tristate "KS0108 LCD Controller" ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] auxdisplay: remove PARPORT dependency 2009-02-07 0:06 [PATCH] auxdisplay: remove PARPORT dependency hartleys @ 2009-02-09 22:37 ` Andrew Morton 2009-02-09 22:46 ` hartleys 0 siblings, 1 reply; 5+ messages in thread From: Andrew Morton @ 2009-02-09 22:37 UTC (permalink / raw) To: hartleys; +Cc: linux-kernel, miguel.ojeda.sandonis (please cc the maintainers on patches) On Fri, 6 Feb 2009 19:06:51 -0500 "hartleys" <hartleys@visionengravers.com> wrote: > Remove PARPORT dependency for Auxiliary Display support. > > This is not needed since the dependency for the KS0108 driver is > PARPORT_PC. > OK, but the patch also accidentally removes the parport dependency from cfag12864b.c and cfag12864bfb.c. A quick grep indicates that those drivers don't need parport, but I didn't look very closely. > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index 14b9d5f..c07e725 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -6,7 +6,6 @@ > # > > menuconfig AUXDISPLAY > - depends on PARPORT > bool "Auxiliary Display support" > ---help--- > Say Y here to get to see options for auxiliary display > drivers. > @@ -14,7 +13,7 @@ menuconfig AUXDISPLAY > > If you say N, all options in this submenu will be skipped and > disabled. > > -if AUXDISPLAY && PARPORT > +if AUXDISPLAY > > config KS0108 > tristate "KS0108 LCD Controller" Your email client wordwraps patches. Please fix that up for next time. ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] auxdisplay: remove PARPORT dependency 2009-02-09 22:37 ` Andrew Morton @ 2009-02-09 22:46 ` hartleys 2009-02-11 10:37 ` Miguel Ojeda 0 siblings, 1 reply; 5+ messages in thread From: hartleys @ 2009-02-09 22:46 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-kernel, miguel.ojeda.sandonis On Monday, February 09, 2009 3:37 PM, Andrew Morton wrote: > (please cc the maintainers on patches) Sorry about missing that. I wasn't sure how patches to Kconfig were handled. >> Remove PARPORT dependency for Auxiliary Display support. >> >> This is not needed since the dependency for the KS0108 driver is >> PARPORT_PC. >> > > OK, but the patch also accidentally removes the parport dependency > from cfag12864b.c and cfag12864bfb.c. > > A quick grep indicates that those drivers don't need parport, but I > didn't look very closely. I think the dependency will be handled automatically. Both cfag12864b.c and cfag12864bfb.c are enabled by CFAG12864B which has a dependency on KS0108, which it turn depends on PARPORT_PC. >> >> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig >> index 14b9d5f..c07e725 100644 >> --- a/drivers/auxdisplay/Kconfig >> +++ b/drivers/auxdisplay/Kconfig >> @@ -6,7 +6,6 @@ >> # >> >> menuconfig AUXDISPLAY >> - depends on PARPORT >> bool "Auxiliary Display support" >> ---help--- >> Say Y here to get to see options for auxiliary display drivers. >> @@ -14,7 +13,7 @@ menuconfig AUXDISPLAY >> >> If you say N, all options in this submenu will be skipped and >> disabled. >> >> -if AUXDISPLAY && PARPORT >> +if AUXDISPLAY >> >> config KS0108 >> tristate "KS0108 LCD Controller" > > Your email client wordwraps patches. Please fix that up for next time. Sorry about that also. Do you have any idea how to correctly configure Outlook to not mess with wordwraps? I know, it's a stupid client, but's that's what I'm stuck with here at work. I've been beating my head with it trying to get it to work correctly. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] auxdisplay: remove PARPORT dependency 2009-02-09 22:46 ` hartleys @ 2009-02-11 10:37 ` Miguel Ojeda 2009-02-11 16:51 ` hartleys 0 siblings, 1 reply; 5+ messages in thread From: Miguel Ojeda @ 2009-02-11 10:37 UTC (permalink / raw) To: hartleys; +Cc: Andrew Morton, linux-kernel On Mon, Feb 9, 2009 at 11:46 PM, hartleys <hartleys@visionengravers.com> wrote: > On Monday, February 09, 2009 3:37 PM, Andrew Morton wrote: >> (please cc the maintainers on patches) > > Sorry about missing that. I wasn't sure how patches to Kconfig were > handled. > >>> Remove PARPORT dependency for Auxiliary Display support. >>> >>> This is not needed since the dependency for the KS0108 driver is >>> PARPORT_PC. >>> >> >> OK, but the patch also accidentally removes the parport dependency >> from cfag12864b.c and cfag12864bfb.c. >> >> A quick grep indicates that those drivers don't need parport, but I >> didn't look very closely. > > I think the dependency will be handled automatically. Both cfag12864b.c > and cfag12864bfb.c are enabled by CFAG12864B which has a dependency on > KS0108, which it turn depends on PARPORT_PC. That's true; however, I think it is intentional: cfag12864bfb depends on cfags12864b, and this one depends on ks0108, which depends on parport and, for the moment, there aren't more entries on "Auxiliary Display support". Thereafter, if PARPORT is not selected, the user is not bothered with an additional menu entry on "Device Drivers". I don't know which is the trend nowadays in this subject (i.e. to show every menu althought empty or not). I see Andrew has already added the patch, so I bet on his decision ;) > >>> >>> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig >>> index 14b9d5f..c07e725 100644 >>> --- a/drivers/auxdisplay/Kconfig >>> +++ b/drivers/auxdisplay/Kconfig >>> @@ -6,7 +6,6 @@ >>> # >>> >>> menuconfig AUXDISPLAY >>> - depends on PARPORT >>> bool "Auxiliary Display support" >>> ---help--- >>> Say Y here to get to see options for auxiliary display > drivers. >>> @@ -14,7 +13,7 @@ menuconfig AUXDISPLAY >>> >>> If you say N, all options in this submenu will be skipped and >>> disabled. >>> >>> -if AUXDISPLAY && PARPORT >>> +if AUXDISPLAY >>> >>> config KS0108 >>> tristate "KS0108 LCD Controller" >> >> Your email client wordwraps patches. Please fix that up for next > time. > > Sorry about that also. Do you have any idea how to correctly configure > Outlook to not mess with wordwraps? I know, it's a stupid client, but's > that's what I'm stuck with here at work. I've been beating my head with > it trying to get it to work correctly. > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] auxdisplay: remove PARPORT dependency 2009-02-11 10:37 ` Miguel Ojeda @ 2009-02-11 16:51 ` hartleys 0 siblings, 0 replies; 5+ messages in thread From: hartleys @ 2009-02-11 16:51 UTC (permalink / raw) To: Miguel Ojeda; +Cc: Andrew Morton, linux-kernel On Wednesday, February 11, 2009 3:38 AM, Miguel Ojeda wrote: >> I think the dependency will be handled automatically. Both >> cfag12864b.c and cfag12864bfb.c are enabled by CFAG12864B which >> has a dependency on KS0108, which it turn depends on PARPORT_PC. > > That's true; however, I think it is intentional: cfag12864bfb > depends on cfags12864b, and this one depends on ks0108, which > depends on parport and, for the moment, there aren't more entries > on "Auxiliary Display support". Thereafter, if PARPORT is not > selected, the user is not bothered with an additional menu entry > on "Device Drivers". > > I don't know which is the trend nowadays in this subject (i.e. to > show every menu althought empty or not). I see Andrew has already > added the patch, so I bet on his decision ;) The arm branch Kconfig was updated awhile back to include auxdisplay. I have been messing with a couple LCD devices similar to the cfag12864. Every time I update my kernel source I have needed to add this patch since my arm platform does not have PARPORT_PC. That was my stimulus for the patch. It does cause the empty menu to appear but some others already do that so I didn't think it was a problem. Regards, Hartley ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-02-11 16:52 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-02-07 0:06 [PATCH] auxdisplay: remove PARPORT dependency hartleys 2009-02-09 22:37 ` Andrew Morton 2009-02-09 22:46 ` hartleys 2009-02-11 10:37 ` Miguel Ojeda 2009-02-11 16:51 ` hartleys
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.