Re: gettext patch (beta)

[Robert Millan <rmh@aybabtu.com>]

Hi Carles

On Sat, Jan 24, 2009 at 03:26:04PM +0100, Carles Pina i Estany wrote:
> Index: Makefile.in
> ===================================================================
> --- Makefile.in	(revision 1954)
> +++ Makefile.in	(working copy)
> @@ -112,6 +112,7 @@
>  PKGDATA = $(pkgdata_DATA) $(pkgdata_SRCDIR)
>  PROGRAMS = $(bin_UTILITIES) $(sbin_UTILITIES)
>  SCRIPTS = $(bin_SCRIPTS) $(sbin_SCRIPTS) $(grub-mkconfig_SCRIPTS)
> +GRUBD = $(srcdir)/util/grub.d

If you're adding GRUBD, perhaps you can use it in other places that currently
hardcode "util/grub.d".

> +"Content-Type: text/plain; charset=CHARSET\n"

That should be charset=utf-8

> +"      Presioneu retorn per arrancar el SO seleccionat, 'e' editar\n"

"l'SO" ;-)

> +"      les comandes abans d'arrancar, 'c' per línia d'ordres."

The 'í' should be in utf-8 (it displays in utf-8 here because
your mailer set Content-Type to iso-8859-1).

> +#: util/grub.d/10_linux.in:148
> +#, sh-format
> +msgid "${OS}, linux ${version} (single-user mode)"
> +msgstr "${OS}, linux ${version} (mode mono-usuari)"

I wonder if we should replace the original string "single-user mode" with
something else.  Novice users find it confusing, since they may assume
"single-user mode" is the normal mode for them (a single user) to use
the computer.

> +          grub_free(current_string);
> +          min=current;
> [...]
> +    current = (max+min)/2;

Remember to add spaces in such places.

> +  if (magic != 0x950412de)

This should be a macro.  Also, it probably needs endian conversion (use the
macros in types.h).

> +  /* Testing:
> +  grub_register_command ("_", grub_cmd_translate, GRUB_COMMAND_FLAG_BOTH,
> +			 "_", "internalization support trans", 0);
> +  */

We could register the "gettext" command and leave it there by default.

> +else
> +  echo "gettext module is not available"
> +fi

This should have ">&2", or it might end up as part of grub.cfg.  Also it
could be more descriptive (like, letting user know text output will be in
English).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."