From: Ingo Molnar <mingo@elte.hu>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Manish Katiyar <mkatiyar@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in
Date: Mon, 16 Feb 2009 15:50:23 +0000 [thread overview]
Message-ID: <20090216155023.GA4422@elte.hu> (raw)
In-Reply-To: <499984C1.6020004@s5r6.in-berlin.de>
* Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> Ingo Molnar wrote:
> > We routinely mention Sparse, lockdep, Coverity, Coccinelle, kmemleak,
> > ftrace, kmemcheck and other tools as well when it motives to fix a bug
> > or uncleanliness. [...] It is absolutely fine to
> > mention checkpatch when it catches uncleanliness in code that already
> > got merged. I dont understand your point.
>
> I wrote "don't mention checkpatch" but I really meant "think about what
> the effect of the patch is and describe this".
Are you arguing that in all those other cases the tools should not be
mentioned either? I dont think that position is tenable.
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Manish Katiyar <mkatiyar@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c
Date: Mon, 16 Feb 2009 16:50:23 +0100 [thread overview]
Message-ID: <20090216155023.GA4422@elte.hu> (raw)
In-Reply-To: <499984C1.6020004@s5r6.in-berlin.de>
* Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> Ingo Molnar wrote:
> > We routinely mention Sparse, lockdep, Coverity, Coccinelle, kmemleak,
> > ftrace, kmemcheck and other tools as well when it motives to fix a bug
> > or uncleanliness. [...] It is absolutely fine to
> > mention checkpatch when it catches uncleanliness in code that already
> > got merged. I dont understand your point.
>
> I wrote "don't mention checkpatch" but I really meant "think about what
> the effect of the patch is and describe this".
Are you arguing that in all those other cases the tools should not be
mentioned either? I dont think that position is tenable.
Ingo
next prev parent reply other threads:[~2009-02-16 15:50 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 18:34 [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Manish Katiyar
2009-02-15 18:46 ` Manish Katiyar
2009-02-15 18:47 ` Sam Ravnborg
2009-02-15 18:47 ` Sam Ravnborg
2009-02-15 18:47 ` Manish Katiyar
2009-02-15 18:59 ` [PATCH] Remove errors caught by checkpatch.pl in Manish Katiyar
2009-02-16 13:07 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Stefan Richter
2009-02-16 13:07 ` Stefan Richter
2009-02-16 13:28 ` [PATCH] Remove errors caught by checkpatch.pl in Ingo Molnar
2009-02-16 13:28 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Ingo Molnar
2009-02-16 14:00 ` Stefan Richter
2009-02-16 14:00 ` Stefan Richter
2009-02-16 14:19 ` [PATCH] Remove errors caught by checkpatch.pl in Ingo Molnar
2009-02-16 14:19 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Ingo Molnar
2009-02-16 15:22 ` Stefan Richter
2009-02-16 15:22 ` Stefan Richter
2009-02-16 15:41 ` Manish Katiyar
2009-02-16 15:53 ` [PATCH] Remove errors caught by checkpatch.pl in Manish Katiyar
2009-02-16 15:50 ` Ingo Molnar [this message]
2009-02-16 15:50 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Ingo Molnar
2009-02-16 16:13 ` Stefan Richter
2009-02-16 16:13 ` Stefan Richter
2009-02-16 17:12 ` [PATCH] Remove errors caught by checkpatch.pl in Ingo Molnar
2009-02-16 17:12 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Ingo Molnar
2009-02-16 18:04 ` Stefan Richter
2009-02-16 18:04 ` Stefan Richter
2009-02-16 16:13 ` [PATCH] Remove errors caught by checkpatch.pl in Al Viro
2009-02-16 16:13 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Al Viro
2009-02-16 17:11 ` [PATCH] Remove errors caught by checkpatch.pl in Ingo Molnar
2009-02-16 17:11 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Ingo Molnar
2009-02-16 14:28 ` [PATCH] Remove errors caught by checkpatch.pl in Paolo Ciarrocchi
2009-02-16 14:28 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Paolo Ciarrocchi
2009-02-16 16:17 ` Julia Lawall
2009-02-16 16:17 ` Julia Lawall
2009-02-16 16:35 ` Stefan Richter
2009-02-16 16:35 ` Stefan Richter
2009-02-16 17:21 ` [PATCH] Remove errors caught by checkpatch.pl in Ingo Molnar
2009-02-16 17:21 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Ingo Molnar
2009-02-16 17:15 ` [PATCH] Remove errors caught by checkpatch.pl in Ingo Molnar
2009-02-16 17:15 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2009-02-15 18:39 [PATCH] Remove errors caught by checkpatch.pl in kernel/utsname_sysctl.c Manish Katiyar
2009-02-15 18:51 ` Manish Katiyar
2009-02-16 13:09 ` Stefan Richter
2009-02-16 13:09 ` Stefan Richter
2009-02-16 14:59 ` Manish Katiyar
2009-02-16 15:11 ` [PATCH] Remove errors caught by checkpatch.pl in Manish Katiyar
2009-02-16 15:34 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/utsname_sysctl.c Stefan Richter
2009-02-16 15:34 ` Stefan Richter
2009-02-15 18:50 [PATCH] Remove errors caught by checkpatch.pl in kernel/acct.c Manish Katiyar
2009-02-15 18:50 ` Manish Katiyar
2009-02-16 13:19 ` Stefan Richter
2009-02-16 13:19 ` Stefan Richter
2009-02-15 19:07 [PATCH] Remove errors caught by checkpatch.pl in kernel/signal.c Manish Katiyar
2009-02-15 19:19 ` Manish Katiyar
2009-02-15 20:08 ` [PATCH] Remove errors caught by checkpatch.pl in Ingo Molnar
2009-02-15 20:08 ` [PATCH] Remove errors caught by checkpatch.pl in kernel/signal.c Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090216155023.GA4422@elte.hu \
--to=mingo@elte.hu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkatiyar@gmail.com \
--cc=sam@ravnborg.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.