[PATCH] IA64: cast has a higher precedence than '?'

[PATCH] IA64: cast has a higher precedence than '?'

[Roel Kluin]

because of the ?: this is not strictly necessary, but I think the added
parentheses are nice here.

--------------------------->8-------------8<------------------------------
A cast has a higher precedence than '?'

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/x86/include/asm/syscall.h b/arch/x86/include/asm/syscall.h
index d82f39b..b8a1933 100644
--- a/arch/x86/include/asm/syscall.h
+++ b/arch/x86/include/asm/syscall.h
@@ -61,7 +61,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
 					    struct pt_regs *regs,
 					    int error, long val)
 {
-	regs->ax = (long) error ?: val;
+	regs->ax = (long) (error ?: val);
 }
 
 #ifdef CONFIG_X86_32

Re: [PATCH] IA64: cast has a higher precedence than '?'

[Ingo Molnar]

* Roel Kluin <roel.kluin@gmail.com> wrote:

> because of the ?: this is not strictly necessary, but I think the added
> parentheses are nice here.
> 
> --------------------------->8-------------8<------------------------------
> A cast has a higher precedence than '?'

> @@ -61,7 +61,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
>  					    struct pt_regs *regs,
>  					    int error, long val)
>  {
> -	regs->ax = (long) error ?: val;
> +	regs->ax = (long) (error ?: val);

it doesnt matter, does it? the 32-bit entity here is 'error', so 
casting it to 64-bit long is just as fine as casting the end 
result to long. In fact this should be the best:

	regs->ax = error ?: val;

as the 32-bit 'error' will be extended to 64 bits anyway.

	Ingo

Re: [PATCH] IA64: cast has a higher precedence than '?'

[Ingo Molnar]

> --- a/arch/x86/include/asm/syscall.h
> +++ b/arch/x86/include/asm/syscall.h

btw., the subject line is wrong	- this is not an ia64 patch but	
an x86 patch.

	Ingo

[PATCH] IA64: cast has a higher precedence than '?'

[Roel Kluin]

A cast has a higher precedence than '?'

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/ia64/include/asm/syscall.h b/arch/ia64/include/asm/syscall.h
index 2f758a4..3fc1832 100644
--- a/arch/ia64/include/asm/syscall.h
+++ b/arch/ia64/include/asm/syscall.h
@@ -64,7 +64,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
 {
 #ifdef CONFIG_IA32_SUPPORT
 	if (IS_IA32_PROCESS(regs)) {
-		regs->r8 = (long) error ? error : val;
+		regs->r8 = (long) (error ? error : val);
 		return;
 	}
 #endif

Re: [PATCH] IA64: cast has a higher precedence than '?'

[Andreas Schwab]

Roel Kluin <roel.kluin@gmail.com> writes:

> diff --git a/arch/ia64/include/asm/syscall.h b/arch/ia64/include/asm/syscall.h
> index 2f758a4..3fc1832 100644
> --- a/arch/ia64/include/asm/syscall.h
> +++ b/arch/ia64/include/asm/syscall.h
> @@ -64,7 +64,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
>  {
>  #ifdef CONFIG_IA32_SUPPORT
>  	if (IS_IA32_PROCESS(regs)) {
> -		regs->r8 = (long) error ? error : val;
> +		regs->r8 = (long) (error ? error : val);

The cast can be removed, it has no influence whatsoever.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."