All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-sdhci@drzeus.cx>
Cc: Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
	Liu Dave <DaveLiu@freescale.com>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	sdhci-devel@list.drzeus.cx
Subject: [PATCH 01/13] sdhci: Add quirk for controllers with no end-of-busy IRQ
Date: Fri, 20 Feb 2009 20:33:08 +0300	[thread overview]
Message-ID: <20090220173308.GA7583@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090220173228.GA5091@oksana.dev.rtsoft.ru>

From: Ben Dooks <ben-linux@fluff.org>

The Samsung SDHCI (and FSL eSDHC) controller block seems to fail
to generate an INT_DATA_END after the transfer has completed and
the bus busy state finished.

Changes in e809517f6fa5803a5a1cd56026f0e2190fc13d5c to use the
new busy method are the cause of the behaviour change.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/mmc/host/sdhci.c |    5 ++++-
 drivers/mmc/host/sdhci.h |    2 ++
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 6b2d1f9..0a1f5c5 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1291,8 +1291,11 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask)
 		if (host->cmd->data)
 			DBG("Cannot wait for busy signal when also "
 				"doing a data transfer");
-		else
+		else if (!(host->quirks & SDHCI_QUIRK_NO_BUSY_IRQ))
 			return;
+
+		/* The controller does not support the end-of-busy IRQ,
+		 * fall through and take the SDHCI_INT_RESPONSE */
 	}
 
 	if (intmask & SDHCI_INT_RESPONSE)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 3efba23..2d08dd4 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -210,6 +210,8 @@ struct sdhci_host {
 #define SDHCI_QUIRK_BROKEN_SMALL_PIO			(1<<13)
 /* Controller supports high speed but doesn't have the caps bit set */
 #define SDHCI_QUIRK_FORCE_HIGHSPEED			(1<<14)
+/* Controller does not provide transfer-complete interrupt when not busy */
+#define SDHCI_QUIRK_NO_BUSY_IRQ				(1<<15)
 
 	int			irq;		/* Device IRQ */
 	void __iomem *		ioaddr;		/* Mapped address */
-- 
1.5.6.5

WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-sdhci@drzeus.cx>
Cc: Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
	Kumar Gala <galak@kernel.crashing.org>,
	Liu Dave <DaveLiu@freescale.com>,
	sdhci-devel@list.drzeus.cx, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org
Subject: [PATCH 01/13] sdhci: Add quirk for controllers with no end-of-busy IRQ
Date: Fri, 20 Feb 2009 20:33:08 +0300	[thread overview]
Message-ID: <20090220173308.GA7583@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090220173228.GA5091@oksana.dev.rtsoft.ru>

From: Ben Dooks <ben-linux@fluff.org>

The Samsung SDHCI (and FSL eSDHC) controller block seems to fail
to generate an INT_DATA_END after the transfer has completed and
the bus busy state finished.

Changes in e809517f6fa5803a5a1cd56026f0e2190fc13d5c to use the
new busy method are the cause of the behaviour change.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/mmc/host/sdhci.c |    5 ++++-
 drivers/mmc/host/sdhci.h |    2 ++
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 6b2d1f9..0a1f5c5 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1291,8 +1291,11 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask)
 		if (host->cmd->data)
 			DBG("Cannot wait for busy signal when also "
 				"doing a data transfer");
-		else
+		else if (!(host->quirks & SDHCI_QUIRK_NO_BUSY_IRQ))
 			return;
+
+		/* The controller does not support the end-of-busy IRQ,
+		 * fall through and take the SDHCI_INT_RESPONSE */
 	}
 
 	if (intmask & SDHCI_INT_RESPONSE)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 3efba23..2d08dd4 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -210,6 +210,8 @@ struct sdhci_host {
 #define SDHCI_QUIRK_BROKEN_SMALL_PIO			(1<<13)
 /* Controller supports high speed but doesn't have the caps bit set */
 #define SDHCI_QUIRK_FORCE_HIGHSPEED			(1<<14)
+/* Controller does not provide transfer-complete interrupt when not busy */
+#define SDHCI_QUIRK_NO_BUSY_IRQ				(1<<15)
 
 	int			irq;		/* Device IRQ */
 	void __iomem *		ioaddr;		/* Mapped address */
-- 
1.5.6.5


  reply	other threads:[~2009-02-20 17:33 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20 17:32 [PATCH 0/13] FSL eSDHC support Anton Vorontsov
2009-02-20 17:32 ` Anton Vorontsov
2009-02-20 17:33 ` Anton Vorontsov [this message]
2009-02-20 17:33   ` [PATCH 01/13] sdhci: Add quirk for controllers with no end-of-busy IRQ Anton Vorontsov
2009-02-21 16:05   ` Pierre Ossman
2009-02-21 16:05     ` Pierre Ossman
2009-02-23  1:56     ` Ben Dooks
2009-02-23  1:56       ` Ben Dooks
2009-02-20 17:33 ` [PATCH 02/13] sdhci: Add support for bus-specific IO memory accessors Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 03/13] sdhci: Split card-detection IRQs management from sdhci_init() Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 04/13] sdhci: Enable only relevant (DMA/PIO) interrupts during transfers Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 05/13] sdhci: Add support for card-detection polling Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 06/13] sdhci: Add support for hosts reporting inverted write-protect state Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 07/13] sdhci: Add support for hosts with strict 32 bit addressing Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 08/13] sdhci: Add get_{max,timeout}_clock callbacks Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 09/13] sdhci: Add set_clock callback and a quirk for nonstandard clocks Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 10/13] sdhci: Add quirk for controllers that need small delays for PIO Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 11/13] sdhci: Add quirk for controllers that need IRQ re-init after reset Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 12/13] sdhci: Add quirk for controllers with max. block size up to 4096 bytes Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-20 17:33 ` [PATCH 13/13] mmc: Add OpenFirmware bindings for SDHCI driver Anton Vorontsov
2009-02-20 17:33   ` Anton Vorontsov
2009-02-21 16:01 ` [PATCH 0/13] FSL eSDHC support Pierre Ossman
2009-02-21 16:01   ` Pierre Ossman
  -- strict thread matches above, loose matches on Subject: below --
2009-02-13 14:46 [PATCH RFC " Anton Vorontsov
2009-02-13 14:47 ` [PATCH 01/13] sdhci: Add quirk for controllers with no end-of-busy IRQ Anton Vorontsov
2009-02-13 14:47   ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090220173308.GA7583@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=DaveLiu@freescale.com \
    --cc=arnd@arndb.de \
    --cc=ben-linux@fluff.org \
    --cc=drzeus-sdhci@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sdhci-devel@list.drzeus.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.