Re: [PATCH] Added driver for ISL29003 ambient light sensor

[Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>]

On Thu, Feb 26, 2009 at 09:48:57AM +0100, Jean Delvare wrote:
> On Thu, 26 Feb 2009 00:57:28 +0100, Daniel Mack wrote:
> > This patch adds a driver for Intersil's ISL29003 ambient light sensor
> > device plus some documentation. Inspired by tsl2550.c, a driver for a
> > similar device.
> > 
> > Signed-off-by: Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>
> > ---
> > Moved the driver to drivers/hwmon
> > 
> >  Documentation/hwmon/isl29003 |   62 +++++
> >  drivers/hwmon/Kconfig        |   10 +
> >  drivers/hwmon/Makefile       |    1 +
> >  drivers/hwmon/isl29003.c     |  517 ++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 590 insertions(+), 0 deletions(-)
> >  create mode 100644 Documentation/hwmon/isl29003
> >  create mode 100644 drivers/hwmon/isl29003.c
> 
> Still no luck, sorry. Light sensors have nothing to do with hardware
> monitoring.

I decided to put it there because of 

config SENSORS_APPLESMC
        tristate "Apple SMC (Motion sensor, light sensor, keyboard
	backlight)"

> I think we need a new subsystem for light sensors. drivers/light maybe?
> Or maybe this fits into Jonathan Cameron's industrial I/O subsystem.
> Jonathan, what do you think? If not, maybe a more general subsystem for
> various sensor types (light, pressure, noise, whatever.)
> 
> Me, I don't really care where these drivers go as long as it's not in
> drivers/i2c/chips.

I don't care eighter - who's deciding it then? Just let me know where
you want it and I'll post a new patch.

Thanks,
Daniel