From: James Cloos <cloos@jhcloos.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added driver for ISL29003 ambient light sensor
Date: Sun, 15 Mar 2009 01:41:58 -0400 [thread overview]
Message-ID: <m34oxvfikh.fsf@lugabout.jhcloos.org> (raw)
In-Reply-To: <1236683979-16178-1-git-send-email-daniel@caiaq.de> (Daniel Mack's message of "Tue, 10 Mar 2009 12:19:39 +0100")
>>>>> "Daniel" == Daniel Mack <daniel@caiaq.de> writes:
Trivial comment on the docs:
Daniel> +mode:
Daniel> + 0: diode1's current (unsigned 16bit) (default)
Daniel> + 1: diode1's current (unsigned 16bit)
Daniel> + 2: difference between diodes (l1 - l2, signed 15bit)
That has diode1 twice. Should it, instead, be:
+mode:
+ 0: diode1's current (unsigned 16bit) (default)
+ 1: diode2's current (unsigned 16bit)
+ 2: difference between diodes (l1 - l2, signed 15bit)
?
-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 1024D/ED7DAEA6
next prev parent reply other threads:[~2009-03-15 5:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 11:19 [PATCH] Added driver for ISL29003 ambient light sensor Daniel Mack
2009-03-15 5:41 ` James Cloos [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-25 20:10 Daniel Mack
[not found] ` <1235592618-10880-1-git-send-email-daniel-rDUAYElUppE@public.gmane.org>
2009-02-25 20:19 ` Daniel Mack
2009-02-25 20:21 ` Jean Delvare
[not found] ` <20090225212119.67402391-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-02-25 23:40 ` Daniel Mack
[not found] ` <20090225234004.GA19039-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-02-26 8:50 ` Jean Delvare
2009-02-25 23:57 ` Daniel Mack
[not found] ` <1235606248-13004-1-git-send-email-daniel-rDUAYElUppE@public.gmane.org>
2009-02-26 8:48 ` Jean Delvare
[not found] ` <20090226094857.50d0710d-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-02-26 9:06 ` Daniel Mack
[not found] ` <20090226090651.GA20531-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-02-26 9:42 ` Jean Delvare
[not found] ` <20090226104204.21dd9616-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-02-26 9:57 ` Daniel Mack
2009-03-06 16:00 ` Daniel Mack
[not found] ` <20090306160042.GA17800-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-06 17:24 ` Jean Delvare
[not found] ` <20090306182432.338b0244-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-06 18:09 ` Jonathan Cameron
[not found] ` <49B166E2.5060909-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2009-03-06 18:54 ` Daniel Mack
2009-03-06 18:14 ` Daniel Mack
[not found] ` <20090306181409.GA20135-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-07 10:54 ` Jean Delvare
[not found] ` <20090307115449.32f0ab26-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-07 12:06 ` Daniel Mack
[not found] ` <20090307120631.GA25276-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-07 12:08 ` Jean Delvare
[not found] ` <20090307130818.367bcaad-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-09 21:09 ` Daniel Mack
[not found] ` <20090309210901.GC31367-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-10 8:56 ` Jean Delvare
[not found] ` <20090310095655.3850f0d5-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-10 9:00 ` Daniel Mack
[not found] ` <20090310090007.GB3263-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-10 10:10 ` Jean Delvare
[not found] ` <20090310111014.523df33e-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-10 10:25 ` Daniel Mack
[not found] ` <20090310102534.GC9564-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-10 10:40 ` Jean Delvare
[not found] ` <20090310114011.012d3fcc-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-10 11:01 ` Trilok Soni
[not found] ` <5d5443650903100401j35f13459kcc03adb7dc7e9297-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-03-10 12:11 ` Jonathan Cameron
2009-03-10 13:11 ` Jonathan Cameron
[not found] ` <49B666F9.50209-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2009-03-10 15:15 ` Daniel Mack
2009-03-10 15:15 ` Daniel Mack
[not found] ` <20090310151542.GE9564-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-10 17:49 ` Jonathan Cameron
2009-03-10 17:49 ` Jonathan Cameron
[not found] ` <49B6A843.3090902-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2009-03-11 0:31 ` Daniel Mack
2009-03-11 0:31 ` Daniel Mack
[not found] ` <20090311003155.GB21160-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-11 4:28 ` Andrew Morton
2009-03-11 4:28 ` Andrew Morton
[not found] ` <20090310212826.7d8b3d4e.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-03-11 8:32 ` Daniel Mack
2009-03-11 8:32 ` Daniel Mack
[not found] ` <20090311083252.GB25824-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-11 16:32 ` Andrew Morton
2009-03-11 16:32 ` Andrew Morton
[not found] ` <20090311093234.7e8e5416.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-03-11 16:43 ` Daniel Mack
2009-03-11 16:43 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34oxvfikh.fsf@lugabout.jhcloos.org \
--to=cloos@jhcloos.com \
--cc=daniel@caiaq.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.