All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>
To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>,
	Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Added driver for ISL29003 ambient light sensor
Date: Wed, 11 Mar 2009 17:43:11 +0100	[thread overview]
Message-ID: <20090311164311.GC29871@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090311093234.7e8e5416.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>

On Wed, Mar 11, 2009 at 09:32:34AM -0700, Andrew Morton wrote:
> > Jonathan replied to the posting on linux-i2c and linux-kernel wasn't in
> > the loop, sorry. Find his posting here:
> > 
> > 	http://marc.info/?l=linux-i2c&m=123669064909549&w=2
> 
> OK.  Please always use reply-to-all, guys.

The thread moved from linux-i2c to linux-kernel, hence the trouble.

> > You're right, it should depend on that. You want me so send a patch on
> > top of the other or one that replaces it?
> 
> Either way is OK by me at this time.

Ok, I chose the shorter variant :) See the patch below.

Thanks,
Daniel


>From 9143c849682280ca3b0544e580bc90241c385927 Mon Sep 17 00:00:00 2001
From: Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>
Date: Wed, 11 Mar 2009 17:39:13 +0100
Subject: [PATCH] make isl29003 depend on sysfs


Signed-off-by: Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>
---
 drivers/misc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index b883b19..16e1815 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -225,7 +225,7 @@ config DELL_LAPTOP
 
 config ISL29003
 	tristate "Intersil ISL29003 ambient light sensor"
-	depends on I2C
+	depends on I2C && SYSFS
 	help
 	  If you say yes here you get support for the Intersil ISL29003
 	  ambient light sensor.
-- 
1.6.2

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Mack <daniel@caiaq.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
	Jean Delvare <khali@linux-fr.org>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added driver for ISL29003 ambient light sensor
Date: Wed, 11 Mar 2009 17:43:11 +0100	[thread overview]
Message-ID: <20090311164311.GC29871@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090311093234.7e8e5416.akpm@linux-foundation.org>

On Wed, Mar 11, 2009 at 09:32:34AM -0700, Andrew Morton wrote:
> > Jonathan replied to the posting on linux-i2c and linux-kernel wasn't in
> > the loop, sorry. Find his posting here:
> > 
> > 	http://marc.info/?l=linux-i2c&m=123669064909549&w=2
> 
> OK.  Please always use reply-to-all, guys.

The thread moved from linux-i2c to linux-kernel, hence the trouble.

> > You're right, it should depend on that. You want me so send a patch on
> > top of the other or one that replaces it?
> 
> Either way is OK by me at this time.

Ok, I chose the shorter variant :) See the patch below.

Thanks,
Daniel


>From 9143c849682280ca3b0544e580bc90241c385927 Mon Sep 17 00:00:00 2001
From: Daniel Mack <daniel@caiaq.de>
Date: Wed, 11 Mar 2009 17:39:13 +0100
Subject: [PATCH] make isl29003 depend on sysfs


Signed-off-by: Daniel Mack <daniel@caiaq.de>
---
 drivers/misc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index b883b19..16e1815 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -225,7 +225,7 @@ config DELL_LAPTOP
 
 config ISL29003
 	tristate "Intersil ISL29003 ambient light sensor"
-	depends on I2C
+	depends on I2C && SYSFS
 	help
 	  If you say yes here you get support for the Intersil ISL29003
 	  ambient light sensor.
-- 
1.6.2


  parent reply	other threads:[~2009-03-11 16:43 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25 20:10 [PATCH] Added driver for ISL29003 ambient light sensor Daniel Mack
     [not found] ` <1235592618-10880-1-git-send-email-daniel-rDUAYElUppE@public.gmane.org>
2009-02-25 20:19   ` Daniel Mack
2009-02-25 20:21   ` Jean Delvare
     [not found]     ` <20090225212119.67402391-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-02-25 23:40       ` Daniel Mack
     [not found]         ` <20090225234004.GA19039-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-02-26  8:50           ` Jean Delvare
2009-02-25 23:57       ` Daniel Mack
     [not found]         ` <1235606248-13004-1-git-send-email-daniel-rDUAYElUppE@public.gmane.org>
2009-02-26  8:48           ` Jean Delvare
     [not found]             ` <20090226094857.50d0710d-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-02-26  9:06               ` Daniel Mack
     [not found]                 ` <20090226090651.GA20531-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-02-26  9:42                   ` Jean Delvare
     [not found]                     ` <20090226104204.21dd9616-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-02-26  9:57                       ` Daniel Mack
     [not found]                         ` <20090226095718.GA24575-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-02-26 13:24                           ` [PATCH 1/3] Added empty directories for hardware sensors Daniel Mack
     [not found]                             ` <1235654648-3450-1-git-send-email-daniel-rDUAYElUppE@public.gmane.org>
2009-02-26 13:24                               ` [PATCH 2/3] Added driver for ISL29003 ambient light sensor Daniel Mack
     [not found]                                 ` <1235654648-3450-2-git-send-email-daniel-rDUAYElUppE@public.gmane.org>
2009-02-26 13:24                                   ` [PATCH 3/3] move tsl2550.c to drivers/sensors Daniel Mack
2009-02-28 12:40                               ` [PATCH 1/3] Added empty directories for hardware sensors Daniel Mack
     [not found]                                 ` <20090228124048.GB18336-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-02  5:22                                   ` Trilok Soni
     [not found]                                     ` <5d5443650903012122p795d51cdr18c1a79c606cd496-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-03-02 10:12                                       ` Daniel Mack
2009-03-06 16:00               ` [PATCH] Added driver for ISL29003 ambient light sensor Daniel Mack
     [not found]                 ` <20090306160042.GA17800-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-06 17:24                   ` Jean Delvare
     [not found]                     ` <20090306182432.338b0244-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-06 18:09                       ` Jonathan Cameron
     [not found]                         ` <49B166E2.5060909-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2009-03-06 18:54                           ` Daniel Mack
2009-03-06 18:14                       ` Daniel Mack
     [not found]                         ` <20090306181409.GA20135-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-07 10:54                           ` Jean Delvare
     [not found]                             ` <20090307115449.32f0ab26-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-07 12:06                               ` Daniel Mack
     [not found]                                 ` <20090307120631.GA25276-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-07 12:08                                   ` Jean Delvare
     [not found]                                     ` <20090307130818.367bcaad-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-09 21:09                                       ` Daniel Mack
     [not found]                                         ` <20090309210901.GC31367-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-10  8:56                                           ` Jean Delvare
     [not found]                                             ` <20090310095655.3850f0d5-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-10  9:00                                               ` Daniel Mack
     [not found]                                                 ` <20090310090007.GB3263-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-10 10:10                                                   ` Jean Delvare
     [not found]                                                     ` <20090310111014.523df33e-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-10 10:25                                                       ` Daniel Mack
     [not found]                                                         ` <20090310102534.GC9564-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-10 10:40                                                           ` Jean Delvare
     [not found]                                                             ` <20090310114011.012d3fcc-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-10 11:01                                                               ` Trilok Soni
     [not found]                                                                 ` <5d5443650903100401j35f13459kcc03adb7dc7e9297-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-03-10 12:11                                                                   ` Jonathan Cameron
2009-03-10 13:11                                           ` Jonathan Cameron
     [not found]                                             ` <49B666F9.50209-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2009-03-10 15:15                                               ` Daniel Mack
2009-03-10 15:15                                                 ` Daniel Mack
     [not found]                                                 ` <20090310151542.GE9564-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-10 17:49                                                   ` Jonathan Cameron
2009-03-10 17:49                                                     ` Jonathan Cameron
     [not found]                                                     ` <49B6A843.3090902-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2009-03-11  0:31                                                       ` Daniel Mack
2009-03-11  0:31                                                         ` Daniel Mack
     [not found]                                                         ` <20090311003155.GB21160-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-11  4:28                                                           ` Andrew Morton
2009-03-11  4:28                                                             ` Andrew Morton
     [not found]                                                             ` <20090310212826.7d8b3d4e.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-03-11  8:32                                                               ` Daniel Mack
2009-03-11  8:32                                                                 ` Daniel Mack
     [not found]                                                                 ` <20090311083252.GB25824-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2009-03-11 16:32                                                                   ` Andrew Morton
2009-03-11 16:32                                                                     ` Andrew Morton
     [not found]                                                                     ` <20090311093234.7e8e5416.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-03-11 16:43                                                                       ` Daniel Mack [this message]
2009-03-11 16:43                                                                         ` Daniel Mack
  -- strict thread matches above, loose matches on Subject: below --
2009-03-10 11:19 Daniel Mack
2009-03-15  5:41 ` James Cloos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090311164311.GC29871@buzzloop.caiaq.de \
    --to=daniel-rduayeluppe@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.