Re: [RFC] generic iMX-spi driver

[Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 660 bytes --]


> > @@ -1659,10 +1721,13 @@ static int __exit spi_imx_remove(struct platform_device *pdev)
> >  		return status;
> >  	}
> >  
> > +	if (platform_info->exit)
> > +		platform_info->exit(pdev);
> 
> platform_info can be NULL here if when declaring platform_device platform data was not set.
> In this case you will get crash here.
> Should be if (platform_info && platform_info->exit)

Well, that is the first thing the probe function checks :) It will fail
if there is no platform_data.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 415 bytes --]

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H

[-- Attachment #3: Type: text/plain, Size: 210 bytes --]

_______________________________________________
spi-devel-general mailing list
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/spi-devel-general