Re: [RFC] generic iMX-spi driver

[Paulius Zaleckas <paulius.zaleckas-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>]

Wolfram Sang wrote:
>>> @@ -1659,10 +1721,13 @@ static int __exit spi_imx_remove(struct platform_device *pdev)
>>>  		return status;
>>>  	}
>>>  
>>> +	if (platform_info->exit)
>>> +		platform_info->exit(pdev);
>> platform_info can be NULL here if when declaring platform_device platform data was not set.
>> In this case you will get crash here.
>> Should be if (platform_info && platform_info->exit)
> 
> Well, that is the first thing the probe function checks :) It will fail
> if there is no platform_data. 

OK then. I missed that check :|

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H