Re: [RFC] generic iMX-spi driver

[Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1000 bytes --]

> What it does do though is want to naturally align structure members, so
> it's a good idea to group u8's together up to the next members natural
> boundary.  So:

All the hot-path variables are u32 as I don't want to do shifting there.
The u8-members are all cold-path, so I can use them as shift counters.
They happen to be 8 in V2, so that seems to fit, too (for now that is).
I know about aligning and will keep an eye on this.

One more thing I had in mind: As every access to a register now looks
like

 'regs + drv_data->version->$some_offset'

I also wondered if it would pay off to add the register base to the
offset already in the probe routine, so we then can reduce the access to
simply

'drv_data->version->$some_reg'

But this is for later, after the driver is stable, I think.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 415 bytes --]

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H

[-- Attachment #3: Type: text/plain, Size: 210 bytes --]

_______________________________________________
spi-devel-general mailing list
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/spi-devel-general