Enterprise kills BBMASK

Enterprise kills BBMASK

[Denys Dmytriyenko]

Sorry for the "sensational" subject... :)

Basically, some time back I noticed that BBMASK stopped working. I didn't have 
time to look into it, until today. One of Mickey's commits broke the tree, 
because bunch of recipes require a missing .inc file, leading to Bitbake 
parsing failure.

Now, trying to set BBMASK leads to nothing. The problem is with 
conf/enterprise.conf, which re-sets it to empty if ENTERPRISE_DISTRO is not 
set. So, not matter what you set BBMASK to in your local.conf, it ends up 
being empty. Unfortunately, it can't be done with "+=", as it has to be a 
regular expression...

Any ideas how to fix it?

-- 
Denys

Re: Enterprise kills BBMASK

[Denys Dmytriyenko]

On Mon, Feb 16, 2009 at 09:24:12PM -0500, Denys Dmytriyenko wrote:
> Sorry for the "sensational" subject... :)
> 
> Basically, some time back I noticed that BBMASK stopped working. I didn't have 
> time to look into it, until today. One of Mickey's commits broke the tree, 
> because bunch of recipes require a missing .inc file, leading to Bitbake 
> parsing failure.

Oh, and by the way, after some discussion on irc I ended up adding an "empty" 
fso-image.inc file just to let Bitbake parse through the tree:

http://cgit.openembedded.net/cgit.cgi?url=openembedded/commit/&id=faa823642b911ac367af38cc5625360987b61a98

Mickey, please replace it with the actual file once you get back... :)

-- 
Denys

Re: Enterprise kills BBMASK

[Denys Dmytriyenko]

On Mon, Feb 16, 2009 at 09:24:12PM -0500, Denys Dmytriyenko wrote:
> Sorry for the "sensational" subject... :)
> 
> Basically, some time back I noticed that BBMASK stopped working. I didn't have 
> time to look into it, until today. One of Mickey's commits broke the tree, 
> because bunch of recipes require a missing .inc file, leading to Bitbake 
> parsing failure.
> 
> Now, trying to set BBMASK leads to nothing. The problem is with 
> conf/enterprise.conf, which re-sets it to empty if ENTERPRISE_DISTRO is not 
> set. So, not matter what you set BBMASK to in your local.conf, it ends up 
> being empty. Unfortunately, it can't be done with "+=", as it has to be a 
> regular expression...
> 
> Any ideas how to fix it?

So, does it mean nobody cares that BBMASK is broken? Or maybe I didn't explain 
the problem clearly enough the first time? :)

-- 
Denys

Re: Enterprise kills BBMASK

[Denys Dmytriyenko]

On Tue, Feb 17, 2009 at 05:54:24PM -0500, Denys Dmytriyenko wrote:
> On Mon, Feb 16, 2009 at 09:24:12PM -0500, Denys Dmytriyenko wrote:
> > Sorry for the "sensational" subject... :)
> > 
> > Basically, some time back I noticed that BBMASK stopped working. I didn't have 
> > time to look into it, until today. One of Mickey's commits broke the tree, 
> > because bunch of recipes require a missing .inc file, leading to Bitbake 
> > parsing failure.
> > 
> > Now, trying to set BBMASK leads to nothing. The problem is with 
> > conf/enterprise.conf, which re-sets it to empty if ENTERPRISE_DISTRO is not 
> > set. So, not matter what you set BBMASK to in your local.conf, it ends up 
> > being empty. Unfortunately, it can't be done with "+=", as it has to be a 
> > regular expression...
> > 
> > Any ideas how to fix it?
> 
> So, does it mean nobody cares that BBMASK is broken? Or maybe I didn't explain 
> the problem clearly enough the first time? :)

Thanks to Chris "kergoth" for coming up with the below code for conf/enterprise.conf,
which makes BBMASK work again! Any objections for commiting it? Zecke?

# For the enterprise edition we want to avoid certain packages by default.
BBMASK ?= ""
OLDBBMASK := "${BBMASK}"
BBMASK = "${@base_conditional('ENTERPRISE_DISTRO', '1', base_conditional('OLDBBMASK', '', '', '(${OLDBBMASK})|', d) + '(mp3blaster|mpg123|mpg321|smpeg|liba52|lame|libmad|mpeg2dec|xmms-mad|madplay|python-mad|opie-mediaplayer1-libmadplugin|ffmpeg|mplayer)', '${OLDBBMASK}', d)}"

-- 
Denys