All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] Coding style in sensors daemon (sensord)
@ 2009-03-04  9:11 Andre Prendel
  2009-03-04  9:16 ` Jean Delvare
  0 siblings, 1 reply; 2+ messages in thread
From: Andre Prendel @ 2009-03-04  9:11 UTC (permalink / raw)
  To: lm-sensors

Hi,

looking at the source code in prog/sensord I've seen gnu coding
style. IMO this is really hard to read. In sensors/ and dump/ we are
using the kernel style and I prefer this one.

To be consistent and ease reading and fixing, I will spend some time
to bring the sensord code in shape.

Any objections?

Andre

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [lm-sensors] Coding style in sensors daemon (sensord)
  2009-03-04  9:11 [lm-sensors] Coding style in sensors daemon (sensord) Andre Prendel
@ 2009-03-04  9:16 ` Jean Delvare
  0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2009-03-04  9:16 UTC (permalink / raw)
  To: lm-sensors

Hallo Andre,

On Wed, 4 Mar 2009 10:11:29 +0100, Andre Prendel wrote:
> looking at the source code in prog/sensord I've seen gnu coding
> style. IMO this is really hard to read. In sensors/ and dump/ we are
> using the kernel style and I prefer this one.
> 
> To be consistent and ease reading and fixing, I will spend some time
> to bring the sensord code in shape.
> 
> Any objections?

No objections, please go ahead. sensord was contributed by Merlin
Hughes a long time ago, and while I (and others) spent a significant
amount of time cleaning up the coding style of other parts of the code,
sensord didn't receive too much love over the past few years... Just
the minimum to keep it alive. You are very welcome to improve the
sensord code, be it the style or the code itself.

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-04  9:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-04  9:11 [lm-sensors] Coding style in sensors daemon (sensord) Andre Prendel
2009-03-04  9:16 ` Jean Delvare

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.