[lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu ->

[lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu ->

[Andre Prendel]

This patch series converts the coding style in prog/sensord/ from gnu to
kernel style. So we are consistent all over the project.

The conversion have exposed some very deep indentation levels. So it
was impossible to not break the 80-characters-per-line rule. Some of
them I already fixed, but other ones can only be fixed by
restructuring the code. I will do that in further patches.

--
 args.c    |  462 +++++++++++++++++++-------------------
 chips.c   |  547 +++++++++++++++++++++++----------------------
 lib.c     |  119 +++++----
 rrd.c     |  743
 ++++++++++++++++++++++++++++++++------------------------------
 sense.c   |  399 +++++++++++++++++----------------
 sensord.c |  382 ++++++++++++++++---------------
 sensord.h |   61 ++---
 7 files changed, 1395 insertions(+), 1318 deletions(-)

Andre

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu

[Jean Delvare]

Hallo Andre,

On Mon, 9 Mar 2009 09:44:58 +0100, Andre Prendel wrote:
> This patch series converts the coding style in prog/sensord/ from gnu to
> kernel style. So we are consistent all over the project.
> 
> The conversion have exposed some very deep indentation levels. So it
> was impossible to not break the 80-characters-per-line rule. Some of
> them I already fixed, but other ones can only be fixed by
> restructuring the code. I will do that in further patches.
> 
> --
>  args.c    |  462 +++++++++++++++++++-------------------
>  chips.c   |  547 +++++++++++++++++++++++----------------------
>  lib.c     |  119 +++++----
>  rrd.c     |  743 ++++++++++++++++++++++++++++++++------------------------------
>  sense.c   |  399 +++++++++++++++++----------------
>  sensord.c |  382 ++++++++++++++++---------------
>  sensord.h |   61 ++---
>  7 files changed, 1395 insertions(+), 1318 deletions(-)

No objection from me, feel free to apply all these patches.

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu

[Andre Prendel]

On Mon, Mar 09, 2009 at 11:19:45AM +0100, Jean Delvare wrote:
> Hallo Andre,

Salut Jean,

> 
> On Mon, 9 Mar 2009 09:44:58 +0100, Andre Prendel wrote:
> > This patch series converts the coding style in prog/sensord/ from gnu to
> > kernel style. So we are consistent all over the project.
> > 
> > The conversion have exposed some very deep indentation levels. So it
> > was impossible to not break the 80-characters-per-line rule. Some of
> > them I already fixed, but other ones can only be fixed by
> > restructuring the code. I will do that in further patches.
> > 
> > --
> >  args.c    |  462 +++++++++++++++++++-------------------
> >  chips.c   |  547 +++++++++++++++++++++++----------------------
> >  lib.c     |  119 +++++----
> >  rrd.c     |  743 ++++++++++++++++++++++++++++++++------------------------------
> >  sense.c   |  399 +++++++++++++++++----------------
> >  sensord.c |  382 ++++++++++++++++---------------
> >  sensord.h |   61 ++---
> >  7 files changed, 1395 insertions(+), 1318 deletions(-)
> 
> No objection from me, feel free to apply all these patches.

Applied with your suggestion to patch 6/7.

BTW, how do you send patch series? I use quilt to handle the
patches. The E-Mails I have though written by hand. Maybe I should try
quilt mail. Have you any experiences with it?

Andre

> Thanks,
> -- 
> Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu

[Jean Delvare]

On Mon, 9 Mar 2009 16:49:41 +0100, Andre Prendel wrote:
> On Mon, Mar 09, 2009 at 11:19:45AM +0100, Jean Delvare wrote:
> > Hallo Andre,
> 
> Salut Jean,
> 
> > 
> > On Mon, 9 Mar 2009 09:44:58 +0100, Andre Prendel wrote:
> > > This patch series converts the coding style in prog/sensord/ from gnu to
> > > kernel style. So we are consistent all over the project.
> > > 
> > > The conversion have exposed some very deep indentation levels. So it
> > > was impossible to not break the 80-characters-per-line rule. Some of
> > > them I already fixed, but other ones can only be fixed by
> > > restructuring the code. I will do that in further patches.
> > > 
> > > --
> > >  args.c    |  462 +++++++++++++++++++-------------------
> > >  chips.c   |  547 +++++++++++++++++++++++----------------------
> > >  lib.c     |  119 +++++----
> > >  rrd.c     |  743 ++++++++++++++++++++++++++++++++------------------------------
> > >  sense.c   |  399 +++++++++++++++++----------------
> > >  sensord.c |  382 ++++++++++++++++---------------
> > >  sensord.h |   61 ++---
> > >  7 files changed, 1395 insertions(+), 1318 deletions(-)
> > 
> > No objection from me, feel free to apply all these patches.
> 
> Applied with your suggestion to patch 6/7.

Thanks!

> BTW, how do you send patch series? I use quilt to handle the
> patches. The E-Mails I have though written by hand. Maybe I should try
> quilt mail. Have you any experiences with it?

I've always been too chicken and/or psychorigid to try quilt mail. I
always send my patch series manually, sending 0/N first and then all
the actual patches as a reply to 0/N. But that's quite some work and
error prone, so I'm not sure if I can sanely recommend that.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors