All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl@pobox.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	containers <containers@lists.linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [RFC][PATCH 00/11] track files for checkpointability
Date: Tue, 10 Mar 2009 11:00:00 -0500	[thread overview]
Message-ID: <20090310110000.24893e0c@thinkcentre.lan> (raw)
In-Reply-To: <20090310105702.43eb1402@thinkcentre.lan>

>From 3695fbda6225d2436e4af67a4bce6984df0891be Mon Sep 17 00:00:00 2001
From: Nathan Lynch <ntl@pobox.com>
Date: Mon, 9 Mar 2009 22:36:40 -0500
Subject: [PATCH] ratelimit files_deny_checkpointing output

Any common distribution's boot sequence causes thousands of
"<something> performed an action that cannot be checkpointed"
messages.  Kernels are known to produce other messages of interest at
times, so ratelimit the output of files_deny_checkpointing.


Signed-off-by: Nathan Lynch <ntl@pobox.com>
---
 include/linux/checkpoint.h |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/linux/checkpoint.h b/include/linux/checkpoint.h
index 27366ac..efdb8f0 100644
--- a/include/linux/checkpoint.h
+++ b/include/linux/checkpoint.h
@@ -108,8 +108,10 @@ static inline void __files_deny_checkpointing(const struct task_struct *tsk,
 {
 	if (!test_and_clear_bit(0, &files->may_checkpoint))
 		return;
-	printk(KERN_INFO "%s/%i performed an action that can not be "
-	       "checkpointed at: %s:%d\n", tsk->comm, tsk->pid, file, line);
+	if (printk_ratelimit())
+		printk(KERN_INFO "%s/%i performed an action that can not be "
+				"checkpointed at: %s:%d\n",
+				tsk->comm, tsk->pid, file, line);
 }
 #define files_deny_checkpointing(tsk,f)				\
 	__files_deny_checkpointing(tsk, f, __FILE__, __LINE__)
-- 
1.6.0.6


  reply	other threads:[~2009-03-10 16:00 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-05 16:38 [RFC][PATCH 00/11] track files for checkpointability Dave Hansen
2009-03-05 16:38 ` Dave Hansen
2009-03-05 16:38 ` [RFC][PATCH 01/11] kill '_data' in cr_hdr_fd_data name Dave Hansen
2009-03-05 16:38   ` Dave Hansen
2009-03-05 16:38 ` [RFC][PATCH 02/11] breakout fdinfo sprintf() into its own function Dave Hansen
2009-03-05 16:38 ` Dave Hansen
2009-03-05 16:39 ` [RFC][PATCH 03/11] Introduce generic_file_checkpoint() Dave Hansen
2009-03-05 16:39   ` Dave Hansen
2009-03-05 16:39 ` [RFC][PATCH 04/11] actually use f_op in checkpoint code Dave Hansen
2009-03-05 16:39   ` Dave Hansen
2009-03-05 16:39 ` [RFC][PATCH 05/11] add generic checkpoint f_op to ext fses Dave Hansen
2009-03-05 16:39   ` Dave Hansen
2009-03-13  2:50   ` Oren Laadan
2009-03-13  2:50     ` Oren Laadan
2009-03-05 16:39 ` [RFC][PATCH 06/11] add checkpoint_file_generic() to /proc Dave Hansen
2009-03-05 16:39   ` Dave Hansen
2009-03-05 16:39 ` [RFC][PATCH 07/11] file c/r: expose functions to query fs support Dave Hansen
2009-03-05 16:39   ` Dave Hansen
2009-03-05 16:39 ` [RFC][PATCH 08/11] expose file checkpointability and reasoning in /proc Dave Hansen
2009-03-05 16:39   ` Dave Hansen
2009-03-05 16:39 ` [RFC][PATCH 09/11] check files for checkpointability Dave Hansen
2009-03-05 16:39   ` Dave Hansen
2009-03-09 17:38   ` Matt Helsley
2009-03-12 19:14     ` Dave Hansen
     [not found]     ` <20090309173837.GC7561-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-12 19:14       ` Dave Hansen
2009-03-09 17:38   ` Matt Helsley
2009-03-05 16:39 ` [RFC][PATCH 10/11] add checkpoint/restart compile helper Dave Hansen
2009-03-05 16:39   ` Dave Hansen
2009-03-05 16:39 ` [RFC][PATCH 11/11] optimize c/r check in dup_fd() Dave Hansen
2009-03-05 16:39   ` Dave Hansen
2009-03-05 17:40 ` [RFC][PATCH 00/11] track files for checkpointability Alexey Dobriyan
     [not found]   ` <20090305174037.GA2274-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-03-05 19:16     ` Dave Hansen
2009-03-05 19:16       ` Dave Hansen
2009-03-05 21:08       ` Alexey Dobriyan
2009-03-05 21:08         ` Alexey Dobriyan
2009-03-05 21:27         ` Dave Hansen
2009-03-05 22:00           ` Alexey Dobriyan
     [not found]             ` <20090305220044.GA2819-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-03-05 22:24               ` Dave Hansen
2009-03-06 15:08               ` Greg Kurz
2009-03-05 22:24             ` Dave Hansen
2009-03-06 14:34               ` Serge E. Hallyn
2009-03-06 14:34               ` Serge E. Hallyn
2009-03-06 15:48                 ` Dave Hansen
2009-03-06 16:23                   ` Serge E. Hallyn
2009-03-06 16:23                     ` Serge E. Hallyn
     [not found]                     ` <20090306162337.GA3040-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-06 16:46                       ` Dave Hansen
2009-03-06 16:46                     ` Dave Hansen
2009-03-06 18:24                       ` Serge E. Hallyn
2009-03-06 19:42                         ` Dave Hansen
     [not found]                         ` <20090306182451.GA6307-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-06 19:42                           ` Dave Hansen
2009-03-06 18:24                       ` Serge E. Hallyn
     [not found]                 ` <20090306143425.GA31250-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-06 15:48                   ` Dave Hansen
2009-03-13  3:05                   ` Oren Laadan
2009-03-13  3:05                 ` Oren Laadan
2009-03-06 15:08             ` Greg Kurz
2009-03-06 15:35               ` Serge E. Hallyn
2009-03-06 15:35               ` Serge E. Hallyn
     [not found]                 ` <20090306153549.GA898-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-06 17:36                   ` Cedric Le Goater
2009-03-06 17:36                     ` Cedric Le Goater
     [not found]                     ` <49B15F35.2010909-GANU6spQydw@public.gmane.org>
2009-03-06 18:30                       ` Serge E. Hallyn
2009-03-06 18:30                     ` Serge E. Hallyn
     [not found]                       ` <20090306183055.GA6729-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-11  7:51                         ` Cedric Le Goater
2009-03-11  7:51                       ` Cedric Le Goater
     [not found]                         ` <49B76D91.1020807-GANU6spQydw@public.gmane.org>
2009-03-12 15:30                           ` Serge E. Hallyn
2009-03-12 15:30                             ` Serge E. Hallyn
2009-03-13  6:36                             ` Ensuring c/r maintainability (WAS Re: [RFC][PATCH 00/11] track files for checkpointability) Matt Helsley
2009-03-13 17:53                               ` Serge E. Hallyn
2009-03-05 22:00           ` [RFC][PATCH 00/11] track files for checkpointability Alexey Dobriyan
     [not found]         ` <20090305210840.GA2499-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-03-05 21:27           ` Dave Hansen
2009-03-05 19:44     ` Dave Hansen
2009-03-05 19:44   ` Dave Hansen
2009-03-05 17:40 ` Alexey Dobriyan
2009-03-05 18:13 ` Serge E. Hallyn
2009-03-05 18:16   ` Dave Hansen
     [not found]   ` <20090305181325.GA10666-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-05 18:16     ` Dave Hansen
2009-03-05 18:13 ` Serge E. Hallyn
2009-03-10 15:57 ` Nathan Lynch
2009-03-10 16:00   ` Nathan Lynch [this message]
2009-03-10 16:23     ` Serge E. Hallyn
     [not found]     ` <20090310110000.24893e0c-4v5LP+xe+1byhTdZtsIeww@public.gmane.org>
2009-03-10 16:23       ` Serge E. Hallyn
2009-03-10 16:20   ` Serge E. Hallyn
2009-03-10 17:23     ` Nathan Lynch
     [not found]       ` <20090310122320.313491ce-4v5LP+xe+1byhTdZtsIeww@public.gmane.org>
2009-03-10 17:45         ` Serge E. Hallyn
2009-03-10 17:45       ` Serge E. Hallyn
2009-03-10 17:47         ` Dave Hansen
2009-03-10 22:54           ` what is CONFIG_VZ_GENCALLS Zhaohui Wang
     [not found]         ` <20090310174517.GA12101-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-10 17:47           ` [RFC][PATCH 00/11] track files for checkpointability Dave Hansen
     [not found]     ` <20090310162026.GA9354-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-10 17:23       ` Nathan Lynch
2009-03-10 16:22   ` Dave Hansen
     [not found]   ` <20090310105702.43eb1402-4v5LP+xe+1byhTdZtsIeww@public.gmane.org>
2009-03-10 16:00     ` Nathan Lynch
2009-03-10 16:20     ` Serge E. Hallyn
2009-03-10 16:22     ` Dave Hansen
2009-03-10 15:57 ` Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090310110000.24893e0c@thinkcentre.lan \
    --to=ntl@pobox.com \
    --cc=adobriyan@gmail.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.