From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Matt Mackall <mpm@selenic.com>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
akpm@linux-foundation.org
Subject: [PATCH] acquire mmap semaphore in pagemap_read.
Date: Thu, 12 Mar 2009 11:33:08 +0100 [thread overview]
Message-ID: <20090312113308.6fe18a93@skybase> (raw)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
The walk_page_range function may only be called while holding the mmap
semaphore. Otherwise a concurrent munmap could free a page table that
is read by the generic page table walker.
Cc: Matt Mackall <mpm@selenic.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
fs/proc/task_mmu.c | 2 ++
1 file changed, 2 insertions(+)
diff -urpN linux-2.6/fs/proc/task_mmu.c linux-2.6-patched/fs/proc/task_mmu.c
--- linux-2.6/fs/proc/task_mmu.c 2009-03-12 11:32:51.000000000 +0100
+++ linux-2.6-patched/fs/proc/task_mmu.c 2009-03-12 11:33:16.000000000 +0100
@@ -716,7 +716,9 @@ static ssize_t pagemap_read(struct file
* user buffer is tracked in "pm", and the walk
* will stop when we hit the end of the buffer.
*/
+ down_read(&mm->mmap_sem);
ret = walk_page_range(start_vaddr, end_vaddr, &pagemap_walk);
+ up_read(&mm->mmap_sem);
if (ret == PM_END_OF_BUFFER)
ret = 0;
/* don't need mmap_sem for these, but this looks cleaner */
WARNING: multiple messages have this Message-ID (diff)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Matt Mackall <mpm@selenic.com>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
akpm@linux-foundation.org
Subject: [PATCH] acquire mmap semaphore in pagemap_read.
Date: Thu, 12 Mar 2009 11:33:08 +0100 [thread overview]
Message-ID: <20090312113308.6fe18a93@skybase> (raw)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
The walk_page_range function may only be called while holding the mmap
semaphore. Otherwise a concurrent munmap could free a page table that
is read by the generic page table walker.
Cc: Matt Mackall <mpm@selenic.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
fs/proc/task_mmu.c | 2 ++
1 file changed, 2 insertions(+)
diff -urpN linux-2.6/fs/proc/task_mmu.c linux-2.6-patched/fs/proc/task_mmu.c
--- linux-2.6/fs/proc/task_mmu.c 2009-03-12 11:32:51.000000000 +0100
+++ linux-2.6-patched/fs/proc/task_mmu.c 2009-03-12 11:33:16.000000000 +0100
@@ -716,7 +716,9 @@ static ssize_t pagemap_read(struct file
* user buffer is tracked in "pm", and the walk
* will stop when we hit the end of the buffer.
*/
+ down_read(&mm->mmap_sem);
ret = walk_page_range(start_vaddr, end_vaddr, &pagemap_walk);
+ up_read(&mm->mmap_sem);
if (ret == PM_END_OF_BUFFER)
ret = 0;
/* don't need mmap_sem for these, but this looks cleaner */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2009-03-12 10:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 10:33 Martin Schwidefsky [this message]
2009-03-12 10:33 ` [PATCH] acquire mmap semaphore in pagemap_read Martin Schwidefsky
2009-03-12 11:45 ` Alexey Dobriyan
2009-03-12 11:45 ` Alexey Dobriyan
2009-03-12 11:54 ` Martin Schwidefsky
2009-03-12 11:54 ` Martin Schwidefsky
2009-03-12 15:23 ` Matt Mackall
2009-03-12 15:23 ` Matt Mackall
2009-03-12 15:27 ` Martin Schwidefsky
2009-03-12 15:27 ` Martin Schwidefsky
2009-03-12 15:41 ` Brice Goglin
2009-03-12 15:41 ` Brice Goglin
2009-03-12 15:46 ` Martin Schwidefsky
2009-03-12 15:46 ` Martin Schwidefsky
2009-03-12 15:54 ` Martin Schwidefsky
2009-03-12 15:54 ` Martin Schwidefsky
2009-03-17 12:04 ` Martin Schwidefsky
2009-03-17 12:04 ` Martin Schwidefsky
2009-03-17 16:21 ` Matt Mackall
2009-03-17 16:21 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312113308.6fe18a93@skybase \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.