From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Bug fix for ext2.c
Date: Sat, 14 Mar 2009 17:37:57 +0100 [thread overview]
Message-ID: <20090314163757.GA13991@thorin> (raw)
In-Reply-To: <ca0f59980903140916i62deb797va96a7b0caee098d7@mail.gmail.com>
On Sun, Mar 15, 2009 at 12:16:23AM +0800, Bean wrote:
> Hi,
>
> I've discovered a bug in ext2.c, inside grub_ext2_mount. The mount
> function must return GRUB_ERR_BAD_FS if something goes wrong, because
> grub_fs_probe would stop as soon as it sees a non-GRUB_ERR_BAD_FS
> error, thus preventing other fs driver from detecting the correct fs
> type. This patch fixes the problem.
I think current behaviour is correct. If a failure is triggered by
grub_disk_read(), from grub_fs_probe perspective it means something is
fucked up other than just "this is not the FS we're looking for", so it
should be aware of the difference.
Or is grub_ext2_read_inode() failure the one that's causing trouble for
you?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-03-14 16:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 16:16 [PATCH] Bug fix for ext2.c Bean
2009-03-14 16:37 ` Robert Millan [this message]
2009-03-14 16:56 ` Bean
2009-03-14 17:35 ` Robert Millan
2009-03-14 17:47 ` Bean
2009-03-14 21:27 ` Yoshinori K. Okuji
2009-03-15 6:00 ` Bean
2009-03-15 10:33 ` Felix Zielcke
2009-03-15 15:37 ` Robert Millan
2009-03-17 5:47 ` Bean
2009-03-21 7:35 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090314163757.GA13991@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.