From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Bug fix for ext2.c
Date: Sun, 15 Mar 2009 06:27:34 +0900 [thread overview]
Message-ID: <200903150627.34301.okuji@enbug.org> (raw)
In-Reply-To: <ca0f59980903140916i62deb797va96a7b0caee098d7@mail.gmail.com>
On Sunday 15 March 2009 01:16:23 Bean wrote:
> Hi,
>
> I've discovered a bug in ext2.c, inside grub_ext2_mount. The mount
> function must return GRUB_ERR_BAD_FS if something goes wrong, because
> grub_fs_probe would stop as soon as it sees a non-GRUB_ERR_BAD_FS
> error, thus preventing other fs driver from detecting the correct fs
> type. This patch fixes the problem.
This patch ignores any kind of failure. That's a problem. If you only convert
GRUB_ERR_OUT_OF_RANGE to GRUB_ERR_BAD_FS, I agree.
Regards,
Okuji
next prev parent reply other threads:[~2009-03-14 21:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 16:16 [PATCH] Bug fix for ext2.c Bean
2009-03-14 16:37 ` Robert Millan
2009-03-14 16:56 ` Bean
2009-03-14 17:35 ` Robert Millan
2009-03-14 17:47 ` Bean
2009-03-14 21:27 ` Yoshinori K. Okuji [this message]
2009-03-15 6:00 ` Bean
2009-03-15 10:33 ` Felix Zielcke
2009-03-15 15:37 ` Robert Millan
2009-03-17 5:47 ` Bean
2009-03-21 7:35 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903150627.34301.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.