From: David Miller <davem@davemloft.net>
To: Joakim.Tjernlund@transmode.se
Cc: netdev@vger.kernel.org, leoli@freescale.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ucc_geth: Convert to net_device_ops
Date: Mon, 23 Mar 2009 11:49:28 -0700 (PDT) [thread overview]
Message-ID: <20090323.114928.01832203.davem@davemloft.net> (raw)
In-Reply-To: <OF2EE08546.DF677136-ONC1257582.0037C87E-C1257582.00388BCE@transmode.se>
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Mon, 23 Mar 2009 11:17:39 +0100
> Sorry for the WS damaged patch, but my current company mailer cannot
> handle inline patches. Due to this we are setting up a new mail system
> but it will be a few days before this is ready.
> Therefore I am attaching this patch as well, use that one
> to apply instaed of the inline variant.
This patch has other problems, anyways.
> +#if 0
> +/* not yet */
> + .ndo_set_mac_address = ucc_geth_set_mac_address,
> + .ndo_change_mtu = ucc_geth_change_mtu,
> + .ndo_do_ioctl = ucc_geth_do_ioctl,
> +#endif
Don't do stuff like this, please. Even the code you are
copying from doesn't have the set_mac_address method
assignment proceted by #if 0 stuff.
Just get rid of all the unused stuff completely.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: Joakim.Tjernlund@transmode.se
Cc: leoli@freescale.com, netdev@vger.kernel.org,
linuxppc-dev@ozlabs.org, avorontsov@ru.mvista.com
Subject: Re: [PATCH] ucc_geth: Convert to net_device_ops
Date: Mon, 23 Mar 2009 11:49:28 -0700 (PDT) [thread overview]
Message-ID: <20090323.114928.01832203.davem@davemloft.net> (raw)
In-Reply-To: <OF2EE08546.DF677136-ONC1257582.0037C87E-C1257582.00388BCE@transmode.se>
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Mon, 23 Mar 2009 11:17:39 +0100
> Sorry for the WS damaged patch, but my current company mailer cannot
> handle inline patches. Due to this we are setting up a new mail system
> but it will be a few days before this is ready.
> Therefore I am attaching this patch as well, use that one
> to apply instaed of the inline variant.
This patch has other problems, anyways.
> +#if 0
> +/* not yet */
> + .ndo_set_mac_address = ucc_geth_set_mac_address,
> + .ndo_change_mtu = ucc_geth_change_mtu,
> + .ndo_do_ioctl = ucc_geth_do_ioctl,
> +#endif
Don't do stuff like this, please. Even the code you are
copying from doesn't have the set_mac_address method
assignment proceted by #if 0 stuff.
Just get rid of all the unused stuff completely.
next prev parent reply other threads:[~2009-03-23 18:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 10:17 [PATCH] ucc_geth: Convert to net_device_ops Joakim Tjernlund
2009-03-23 18:49 ` David Miller [this message]
2009-03-23 18:49 ` David Miller
2009-03-24 10:37 ` Joakim Tjernlund
2009-03-24 10:37 ` Joakim Tjernlund
2009-03-24 21:22 ` David Miller
2009-03-24 21:22 ` David Miller
2009-03-24 22:45 ` Joakim Tjernlund
2009-03-24 22:45 ` Joakim Tjernlund
2009-03-24 22:49 ` David Miller
2009-03-24 23:08 ` Joakim Tjernlund
2009-03-24 23:08 ` Joakim Tjernlund
2009-03-24 23:29 ` David Miller
2009-03-24 23:29 ` David Miller
2009-03-24 23:35 ` Joakim Tjernlund
2009-03-24 23:35 ` Joakim Tjernlund
2009-03-27 18:50 ` Timur Tabi
2009-03-27 18:50 ` Timur Tabi
2009-03-28 11:27 ` Joakim Tjernlund
2009-03-28 11:27 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323.114928.01832203.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joakim.Tjernlund@transmode.se \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.