From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: bridge@lists.linux-foundation.org, leoli@freescale.com,
netdev@vger.kernel.org
Subject: Re: [Bridge] [PATCH] net/bridge: use the maximum hard_header_len of ports for bridging device
Date: Mon, 23 Mar 2009 15:47:51 -0700 (PDT) [thread overview]
Message-ID: <20090323.154751.190788467.davem@davemloft.net> (raw)
In-Reply-To: <20090323154517.2146a357@nehalam>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Mon, 23 Mar 2009 15:45:17 -0700
> So you dynamically compute the additional space but if the space was
> an awkward size, could it cause driver to breaks alignment assumptions?
Yes, you'd need to 16-byte align or something like that.
> And you didn't fixup the skb that is about to gag in the skb to make
> more space, so transmitting device driver (gfar) is going to overwrite or die.
This particular instance will do the headroom reallocation,
that's unavoidable during the size transition event.
The headroom checks can't ever be removed, but we won't hit
them in the fast path after the adjustment is made by my
patch.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: leoli@freescale.com, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net/bridge: use the maximum hard_header_len of ports for bridging device
Date: Mon, 23 Mar 2009 15:47:51 -0700 (PDT) [thread overview]
Message-ID: <20090323.154751.190788467.davem@davemloft.net> (raw)
In-Reply-To: <20090323154517.2146a357@nehalam>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Mon, 23 Mar 2009 15:45:17 -0700
> So you dynamically compute the additional space but if the space was
> an awkward size, could it cause driver to breaks alignment assumptions?
Yes, you'd need to 16-byte align or something like that.
> And you didn't fixup the skb that is about to gag in the skb to make
> more space, so transmitting device driver (gfar) is going to overwrite or die.
This particular instance will do the headroom reallocation,
that's unavoidable during the size transition event.
The headroom checks can't ever be removed, but we won't hit
them in the fast path after the adjustment is made by my
patch.
next prev parent reply other threads:[~2009-03-23 22:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 9:04 [Bridge] [PATCH] net/bridge: use the maximum hard_header_len of ports for bridging device Li Yang
2009-03-20 9:04 ` Li Yang
2009-03-23 7:59 ` [Bridge] " Li Yang
2009-03-23 7:59 ` Li Yang
2009-03-23 8:02 ` [Bridge] " David Miller
2009-03-23 8:02 ` David Miller
2009-03-23 8:15 ` [Bridge] " Li Yang
2009-03-23 8:15 ` Li Yang
2009-03-23 8:16 ` [Bridge] " David Miller
2009-03-23 8:16 ` David Miller
2009-03-23 15:51 ` [Bridge] " Stephen Hemminger
2009-03-23 15:51 ` Stephen Hemminger
2009-03-23 22:20 ` [Bridge] " David Miller
2009-03-23 22:20 ` David Miller
2009-03-23 22:45 ` [Bridge] " Stephen Hemminger
2009-03-23 22:45 ` Stephen Hemminger
2009-03-23 22:47 ` David Miller [this message]
2009-03-23 22:47 ` David Miller
2009-03-25 8:43 ` [Bridge] " Li Yang
2009-03-25 8:43 ` Li Yang
2009-03-25 21:35 ` [Bridge] " David Miller
2009-03-25 21:35 ` David Miller
2009-03-25 6:40 ` [Bridge] " David Miller
2009-03-25 6:40 ` David Miller
2009-03-25 7:05 ` [Bridge] " Li Yang
2009-03-25 7:05 ` Li Yang
2009-03-25 7:06 ` [Bridge] " David Miller
2009-03-25 7:06 ` David Miller
2009-03-25 8:38 ` [Bridge] " Li Yang
2009-03-25 8:38 ` Li Yang
2009-03-25 9:15 ` [PATCH] gianfar: reallocate skb when headroom is not enough for fcb Li Yang
2009-03-25 15:53 ` Stephen Hemminger
2009-03-25 21:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323.154751.190788467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=leoli@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.