From: David Miller <davem@davemloft.net>
To: leoli@freescale.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH] net/bridge: use the maximum hard_header_len of ports for bridging device
Date: Wed, 25 Mar 2009 14:35:58 -0700 (PDT) [thread overview]
Message-ID: <20090325.143558.35670359.davem@davemloft.net> (raw)
In-Reply-To: <2a27d3730903250143u58a3c67dp132a8a5755d50d93@mail.gmail.com>
From: Li Yang <leoli@freescale.com>
Date: Wed, 25 Mar 2009 16:43:53 +0800
> Dynamically adjusting is a good idea, but the rx_alloc_extra can only
> go up not the other way down in your code.
That's not a problem.
> Another thought is that if you re-allocate skb here the driver would
> be saved from checking the headroom in the fastpath, am I right?
You're going to need it for other paths. There are other kinds of
tunnels et al. that eat that headroom space on you.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: leoli@freescale.com
Cc: shemminger@linux-foundation.org,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net/bridge: use the maximum hard_header_len of ports for bridging device
Date: Wed, 25 Mar 2009 14:35:58 -0700 (PDT) [thread overview]
Message-ID: <20090325.143558.35670359.davem@davemloft.net> (raw)
In-Reply-To: <2a27d3730903250143u58a3c67dp132a8a5755d50d93@mail.gmail.com>
From: Li Yang <leoli@freescale.com>
Date: Wed, 25 Mar 2009 16:43:53 +0800
> Dynamically adjusting is a good idea, but the rx_alloc_extra can only
> go up not the other way down in your code.
That's not a problem.
> Another thought is that if you re-allocate skb here the driver would
> be saved from checking the headroom in the fastpath, am I right?
You're going to need it for other paths. There are other kinds of
tunnels et al. that eat that headroom space on you.
next prev parent reply other threads:[~2009-03-25 21:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 9:04 [Bridge] [PATCH] net/bridge: use the maximum hard_header_len of ports for bridging device Li Yang
2009-03-20 9:04 ` Li Yang
2009-03-23 7:59 ` [Bridge] " Li Yang
2009-03-23 7:59 ` Li Yang
2009-03-23 8:02 ` [Bridge] " David Miller
2009-03-23 8:02 ` David Miller
2009-03-23 8:15 ` [Bridge] " Li Yang
2009-03-23 8:15 ` Li Yang
2009-03-23 8:16 ` [Bridge] " David Miller
2009-03-23 8:16 ` David Miller
2009-03-23 15:51 ` [Bridge] " Stephen Hemminger
2009-03-23 15:51 ` Stephen Hemminger
2009-03-23 22:20 ` [Bridge] " David Miller
2009-03-23 22:20 ` David Miller
2009-03-23 22:45 ` [Bridge] " Stephen Hemminger
2009-03-23 22:45 ` Stephen Hemminger
2009-03-23 22:47 ` [Bridge] " David Miller
2009-03-23 22:47 ` David Miller
2009-03-25 8:43 ` [Bridge] " Li Yang
2009-03-25 8:43 ` Li Yang
2009-03-25 21:35 ` David Miller [this message]
2009-03-25 21:35 ` David Miller
2009-03-25 6:40 ` [Bridge] " David Miller
2009-03-25 6:40 ` David Miller
2009-03-25 7:05 ` [Bridge] " Li Yang
2009-03-25 7:05 ` Li Yang
2009-03-25 7:06 ` [Bridge] " David Miller
2009-03-25 7:06 ` David Miller
2009-03-25 8:38 ` [Bridge] " Li Yang
2009-03-25 8:38 ` Li Yang
2009-03-25 9:15 ` [PATCH] gianfar: reallocate skb when headroom is not enough for fcb Li Yang
2009-03-25 15:53 ` Stephen Hemminger
2009-03-25 21:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325.143558.35670359.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=leoli@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.