From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Roland McGrath <roland@redhat.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 1/5] ptrace: remove incorrect unlikelys
Date: Wed, 25 Mar 2009 01:19:21 -0400 [thread overview]
Message-ID: <20090325052022.747507467@goodmis.org> (raw)
In-Reply-To: 20090325051920.406564281@goodmis.org
[-- Attachment #1: 0001-ptrace-remove-incorrect-unlikelys.patch --]
[-- Type: text/plain, Size: 1409 bytes --]
From: Steven Rostedt <rostedt@goodmis.org>
Impact: clean up
Accounding to the annotated branch profiler, the unlikelys used by
ptrace is incorrect every time.
correct incorrect % Function File Line
------- --------- - -------- ---- ----
0 24176 100 syscall_trace_leave ptrace.c 1444
0 21478 100 syscall_trace_enter ptrace.c 1424
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
arch/x86/kernel/ptrace.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index 06ca07f..74a16db 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -1421,7 +1421,7 @@ asmregparm long syscall_trace_enter(struct pt_regs *regs)
tracehook_report_syscall_entry(regs))
ret = -1L;
- if (unlikely(current->audit_context)) {
+ if (current->audit_context) {
if (IS_IA32)
audit_syscall_entry(AUDIT_ARCH_I386,
regs->orig_ax,
@@ -1441,7 +1441,7 @@ asmregparm long syscall_trace_enter(struct pt_regs *regs)
asmregparm void syscall_trace_leave(struct pt_regs *regs)
{
- if (unlikely(current->audit_context))
+ if (current->audit_context)
audit_syscall_exit(AUDITSC_RESULT(regs->ax), regs->ax);
if (test_thread_flag(TIF_SYSCALL_TRACE))
--
1.6.2
--
next prev parent reply other threads:[~2009-03-25 5:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 5:19 [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys Steven Rostedt
2009-03-25 5:19 ` Steven Rostedt [this message]
2009-03-25 7:21 ` [PATCH 1/5] ptrace: remove incorrect unlikelys Ingo Molnar
2009-03-25 13:31 ` Christian Borntraeger
2009-03-25 13:42 ` Steven Rostedt
2009-03-25 9:28 ` Roland McGrath
2009-03-25 5:19 ` [PATCH 2/5] mm: remove unlikly NULL from kfree Steven Rostedt
2009-03-25 7:34 ` Pekka Enberg
2009-03-25 7:50 ` Thomas Gleixner
2009-03-25 8:01 ` Pekka Enberg
2009-03-25 21:20 ` Andrew Morton
2009-03-25 8:02 ` Hua Zhong
2009-03-25 8:06 ` Pekka Enberg
2009-03-25 13:51 ` Pekka Enberg
2009-03-25 14:47 ` Steven Rostedt
2009-03-25 14:59 ` Pekka Enberg
2009-03-25 15:04 ` Steven Rostedt
2009-03-25 15:08 ` Steven Rostedt
2009-03-25 16:14 ` Matt Mackall
2009-03-25 16:34 ` Steven Rostedt
2009-03-25 20:26 ` Jeremy Fitzhardinge
2009-03-25 21:09 ` Matt Mackall
2009-03-25 21:01 ` Matt Mackall
2009-03-25 21:24 ` Steven Rostedt
2009-03-25 15:27 ` Steven Rostedt
2009-03-26 16:10 ` Al Viro
2009-03-26 16:15 ` Andrew Morton
2009-03-25 5:19 ` [PATCH 3/5] sched: remove unlikely in pre_schedule_rt Steven Rostedt
2009-03-25 5:24 ` Steven Rostedt
2009-03-25 5:19 ` [PATCH 4/5] sched: remove unlikelys from sched_move_task Steven Rostedt
2009-03-25 5:19 ` [PATCH 5/5] mm: remove unlikelys for unlock in rmap.c Steven Rostedt
2009-04-24 11:12 ` KOSAKI Motohiro
2009-04-24 12:15 ` Lee Schermerhorn
2009-03-25 7:19 ` [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys Ingo Molnar
2009-03-25 7:25 ` Ingo Molnar
2009-03-25 13:43 ` Steven Rostedt
2009-04-27 16:30 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325052022.747507467@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.