From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Roland McGrath <roland@redhat.com>,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys
Date: Wed, 25 Mar 2009 08:25:01 +0100 [thread overview]
Message-ID: <20090325072501.GC25833@elte.hu> (raw)
In-Reply-To: <20090325051920.406564281@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> ----
> arch/x86/kernel/ptrace.c | 4 ++--
> kernel/sched.c | 4 ++--
> kernel/sched_rt.c | 2 +-
> mm/rmap.c | 8 ++++----
> mm/slab.c | 2 +-
> mm/slob.c | 2 +-
> mm/slub.c | 2 +-
> 7 files changed, 12 insertions(+), 12 deletions(-)
I commented on the ptrace one - i think we should take that one out
or at least wait for more info.
The MM ones look correct. Maybe your kfree observation will be
debated - but i think it's probably right that we should not special
annotate kfree(NULL) anymore in any direction. But it's ultimately
up to the MM folks. (I've Cc:-ed Pekka too)
The rmap and the scheduler ones definitely look correct. When you
rebase, please include the profiler output to 3/5 too.
Thanks,
Ingo
next prev parent reply other threads:[~2009-03-25 7:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 5:19 [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys Steven Rostedt
2009-03-25 5:19 ` [PATCH 1/5] ptrace: remove incorrect unlikelys Steven Rostedt
2009-03-25 7:21 ` Ingo Molnar
2009-03-25 13:31 ` Christian Borntraeger
2009-03-25 13:42 ` Steven Rostedt
2009-03-25 9:28 ` Roland McGrath
2009-03-25 5:19 ` [PATCH 2/5] mm: remove unlikly NULL from kfree Steven Rostedt
2009-03-25 7:34 ` Pekka Enberg
2009-03-25 7:50 ` Thomas Gleixner
2009-03-25 8:01 ` Pekka Enberg
2009-03-25 21:20 ` Andrew Morton
2009-03-25 8:02 ` Hua Zhong
2009-03-25 8:06 ` Pekka Enberg
2009-03-25 13:51 ` Pekka Enberg
2009-03-25 14:47 ` Steven Rostedt
2009-03-25 14:59 ` Pekka Enberg
2009-03-25 15:04 ` Steven Rostedt
2009-03-25 15:08 ` Steven Rostedt
2009-03-25 16:14 ` Matt Mackall
2009-03-25 16:34 ` Steven Rostedt
2009-03-25 20:26 ` Jeremy Fitzhardinge
2009-03-25 21:09 ` Matt Mackall
2009-03-25 21:01 ` Matt Mackall
2009-03-25 21:24 ` Steven Rostedt
2009-03-25 15:27 ` Steven Rostedt
2009-03-26 16:10 ` Al Viro
2009-03-26 16:15 ` Andrew Morton
2009-03-25 5:19 ` [PATCH 3/5] sched: remove unlikely in pre_schedule_rt Steven Rostedt
2009-03-25 5:24 ` Steven Rostedt
2009-03-25 5:19 ` [PATCH 4/5] sched: remove unlikelys from sched_move_task Steven Rostedt
2009-03-25 5:19 ` [PATCH 5/5] mm: remove unlikelys for unlock in rmap.c Steven Rostedt
2009-04-24 11:12 ` KOSAKI Motohiro
2009-04-24 12:15 ` Lee Schermerhorn
2009-03-25 7:19 ` [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys Ingo Molnar
2009-03-25 7:25 ` Ingo Molnar [this message]
2009-03-25 13:43 ` Steven Rostedt
2009-04-27 16:30 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325072501.GC25833@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.