From: Theodore Tso <tytso@mit.edu>
To: Chris Mason <chris.mason@oracle.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix blkdev_issue_flush() failure handling
Date: Mon, 30 Mar 2009 13:46:07 -0400 [thread overview]
Message-ID: <20090330174607.GR13356@mit.edu> (raw)
In-Reply-To: <1238413667.30488.2.camel@think.oraclecorp.com>
On Mon, Mar 30, 2009 at 07:47:47AM -0400, Chris Mason wrote:
> > Yes, it was. Although I got the idea when hch pointed out that SuSE did
> > this... thanks to Chris. It's come full circle. :)
>
> Grin. I'm not sure the I_DIRTY checks alone are enough to decide that a
> commit is required though. I think the inode could be clean but still
> have metadata that needs commit.
So to close this hole, I think what we can do is to track the last
transaction id where ext4_do_update_inode() was called, and if that
transaction id == the currently running transaction id, then we need
to call ext4_force_commit() even though the inode is clean. I think
that should fix up the race that you're concerned about.
- Ted
prev parent reply other threads:[~2009-03-30 17:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 17:28 [PATCH] ext4: fix blkdev_issue_flush() failure handling Bartlomiej Zolnierkiewicz
2009-03-29 17:43 ` Eric Sandeen
2009-03-30 2:25 ` Theodore Tso
2009-03-30 3:22 ` Eric Sandeen
2009-03-30 11:47 ` Chris Mason
2009-03-30 13:01 ` Fernando Luis Vázquez Cao
2009-03-30 13:24 ` Chris Mason
2009-03-31 4:28 ` Fernando Luis Vázquez Cao
2009-03-31 4:28 ` Fernando Luis Vázquez Cao
2009-03-30 14:25 ` Theodore Tso
2009-03-30 14:25 ` Theodore Tso
2009-03-31 4:33 ` Fernando Luis Vázquez Cao
2009-03-31 4:33 ` Fernando Luis Vázquez Cao
2009-03-30 15:26 ` Bartlomiej Zolnierkiewicz
2009-03-30 15:26 ` Bartlomiej Zolnierkiewicz
2009-03-31 4:23 ` Fernando Luis Vázquez Cao
2009-03-31 4:23 ` Fernando Luis Vázquez Cao
2009-03-30 17:46 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330174607.GR13356@mit.edu \
--to=tytso@mit.edu \
--cc=bzolnier@gmail.com \
--cc=chris.mason@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.