From: Theodore Tso <tytso@mit.edu>
To: "Fernando Luis Vázquez Cao" <flvazquez@uvigo.es>
Cc: Chris Mason <chris.mason@oracle.com>,
Eric Sandeen <sandeen@redhat.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix blkdev_issue_flush() failure handling
Date: Mon, 30 Mar 2009 10:25:18 -0400 [thread overview]
Message-ID: <20090330142518.GI13356@mit.edu> (raw)
In-Reply-To: <49D0C29C.1060307@uvigo.es>
On Mon, Mar 30, 2009 at 10:01:16PM +0900, Fernando Luis Vázquez Cao wrote:
>
> Chris, I have just sent patches that attempt to fix both ext3 and
> ext4 while also adding a per-device sysfs knob tu disable
> write-flushes. A previous version of this patch set added a new
> generic mount option but comments from Christoph and others
> convinced me to turn it into a per-device tunable. Could you take
> a look at the patches?
Fernando, see my comments on those patches. We don't need to issue a
barrier after a call to sync_inode() or ext[34]_force_commit(), since
those functions will issue a barrier for us. It would probably be a
good idea to use blktrace to test and make sure that we have one and
exactly one barrier op issued for each fsync().
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Tso <tytso@mit.edu>
To: "Fernando Luis Vázquez Cao" <flvazquez@uvigo.es>
Cc: Chris Mason <chris.mason@oracle.com>,
Eric Sandeen <sandeen@redhat.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix blkdev_issue_flush() failure handling
Date: Mon, 30 Mar 2009 10:25:18 -0400 [thread overview]
Message-ID: <20090330142518.GI13356@mit.edu> (raw)
In-Reply-To: <49D0C29C.1060307@uvigo.es>
On Mon, Mar 30, 2009 at 10:01:16PM +0900, Fernando Luis Vázquez Cao wrote:
>
> Chris, I have just sent patches that attempt to fix both ext3 and
> ext4 while also adding a per-device sysfs knob tu disable
> write-flushes. A previous version of this patch set added a new
> generic mount option but comments from Christoph and others
> convinced me to turn it into a per-device tunable. Could you take
> a look at the patches?
Fernando, see my comments on those patches. We don't need to issue a
barrier after a call to sync_inode() or ext[34]_force_commit(), since
those functions will issue a barrier for us. It would probably be a
good idea to use blktrace to test and make sure that we have one and
exactly one barrier op issued for each fsync().
- Ted
next prev parent reply other threads:[~2009-03-30 14:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 17:28 [PATCH] ext4: fix blkdev_issue_flush() failure handling Bartlomiej Zolnierkiewicz
2009-03-29 17:43 ` Eric Sandeen
2009-03-30 2:25 ` Theodore Tso
2009-03-30 3:22 ` Eric Sandeen
2009-03-30 11:47 ` Chris Mason
2009-03-30 13:01 ` Fernando Luis Vázquez Cao
2009-03-30 13:24 ` Chris Mason
2009-03-31 4:28 ` Fernando Luis Vázquez Cao
2009-03-31 4:28 ` Fernando Luis Vázquez Cao
2009-03-30 14:25 ` Theodore Tso [this message]
2009-03-30 14:25 ` Theodore Tso
2009-03-31 4:33 ` Fernando Luis Vázquez Cao
2009-03-31 4:33 ` Fernando Luis Vázquez Cao
2009-03-30 15:26 ` Bartlomiej Zolnierkiewicz
2009-03-30 15:26 ` Bartlomiej Zolnierkiewicz
2009-03-31 4:23 ` Fernando Luis Vázquez Cao
2009-03-31 4:23 ` Fernando Luis Vázquez Cao
2009-03-30 17:46 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330142518.GI13356@mit.edu \
--to=tytso@mit.edu \
--cc=bzolnier@gmail.com \
--cc=chris.mason@oracle.com \
--cc=flvazquez@uvigo.es \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.