All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Theodore Tso <tytso@mit.edu>, Eric Sandeen <sandeen@redhat.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix blkdev_issue_flush() failure handling
Date: Sun, 29 Mar 2009 22:22:09 -0500	[thread overview]
Message-ID: <49D03AE1.8070009@redhat.com> (raw)
In-Reply-To: <20090330022521.GB13356@mit.edu>

Theodore Tso wrote:
> On Sun, Mar 29, 2009 at 12:43:22PM -0500, Eric Sandeen wrote:
>> As long as we keep the call there this is probably good, but after
>> talking w/ Chris Mason, I think the call is extraneous anyway and should
>> probably just be removed...
>>
> 
> Yes, I agree, but it takes a lot of digging to be completely sure of
> that it's safe to remove it.  Interestingly, it was you who added the
> patch which added the call to blkdev_issue_flush():

> commit d755fb384250d6bd7fd18a0930e71965acc8e72e
> Author: Eric Sandeen <sandeen@redhat.com>
> Date:   Fri Jul 11 19:27:31 2008 -0400


Yes, it was.  Although I got the idea when hch pointed out that SuSE did
this... thanks to Chris.  It's come full circle.  :)

-Eric

  reply	other threads:[~2009-03-30  3:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-29 17:28 [PATCH] ext4: fix blkdev_issue_flush() failure handling Bartlomiej Zolnierkiewicz
2009-03-29 17:43 ` Eric Sandeen
2009-03-30  2:25   ` Theodore Tso
2009-03-30  3:22     ` Eric Sandeen [this message]
2009-03-30 11:47       ` Chris Mason
2009-03-30 13:01         ` Fernando Luis Vázquez Cao
2009-03-30 13:24           ` Chris Mason
2009-03-31  4:28             ` Fernando Luis Vázquez Cao
2009-03-31  4:28               ` Fernando Luis Vázquez Cao
2009-03-30 14:25           ` Theodore Tso
2009-03-30 14:25             ` Theodore Tso
2009-03-31  4:33             ` Fernando Luis Vázquez Cao
2009-03-31  4:33               ` Fernando Luis Vázquez Cao
2009-03-30 15:26           ` Bartlomiej Zolnierkiewicz
2009-03-30 15:26             ` Bartlomiej Zolnierkiewicz
2009-03-31  4:23             ` Fernando Luis Vázquez Cao
2009-03-31  4:23               ` Fernando Luis Vázquez Cao
2009-03-30 17:46         ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D03AE1.8070009@redhat.com \
    --to=sandeen@redhat.com \
    --cc=bzolnier@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.