Re: [Qemu-devel] [PATCH 06/19] Bug fix alpha: stop translation if too long

[Aurelien Jarno <aurelien@aurel32.net>]

On Mon, Mar 30, 2009 at 04:36:21PM +0200, Tristan Gingold wrote:
> Signed-off-by: Tristan Gingold <gingold@adacore.com>
> ---
>  target-alpha/translate.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

I have applied a slightly different patch to split the tests into
different if for better readability. Thanks.

> diff --git a/target-alpha/translate.c b/target-alpha/translate.c
> index e9463ae..dad1686 100644
> --- a/target-alpha/translate.c
> +++ b/target-alpha/translate.c
> @@ -2401,10 +2401,10 @@ static always_inline void gen_intermediate_code_internal (CPUState *env,
>          ret = translate_one(ctxp, insn);
>          if (ret != 0)
>              break;
> -        /* if we reach a page boundary or are single stepping, stop
> -         * generation
> -         */
> +        /* if we reach a page boundary, or translation is too long
> +           or are single stepping, stop generation.  */
>          if (((ctx.pc & (TARGET_PAGE_SIZE - 1)) == 0) ||
> +            gen_opc_ptr >= gen_opc_end ||
>              num_insns >= max_insns) {
>              break;
>          }
> -- 
> 1.6.2
> 
> 
> 
> 

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net