From: Arnd Bergmann <arnd@arndb.de>
To: Kevin Cernekee <kpc.mtd@gmail.com>
Cc: Linux MTD <linux-mtd@lists.infradead.org>,
David Woodhouse <dwmw2@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH 3/4] [MTD] compat_ioctl cleanup
Date: Tue, 14 Apr 2009 16:43:47 +0200 [thread overview]
Message-ID: <200904141643.48345.arnd@arndb.de> (raw)
In-Reply-To: <a95a62fe0904082253i119f8660y6a73835a163394f5@mail.gmail.com>
On Thursday 09 April 2009, Kevin Cernekee wrote:
>
> 1) Move the MEMREADOOB/MEMWRITEOOB compat_ioctl wrappers from
> fs/compat_ioctl.c into mtdchar.c . Original request was here:
>
> http://lkml.org/lkml/2009/4/1/295
Very nice cleanup, thanks for doing this!
> 2) Add missing COMPATIBLE_IOCTL lines, so that mtd-utils does not error
> out when running in 64/32 compatibility mode.
This looks correct, but I think it would be better to just remove all
those lines from fs/compat_ioctl.c and add a default: statement in
mtd_compat_ioctl that calls mtd_ioctl for all ioctl numbers that
don't have an explicit handler.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Kevin Cernekee <kpc.mtd@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Adrian Hunter <adrian.hunter@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MTD <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 3/4] [MTD] compat_ioctl cleanup
Date: Tue, 14 Apr 2009 16:43:47 +0200 [thread overview]
Message-ID: <200904141643.48345.arnd@arndb.de> (raw)
In-Reply-To: <a95a62fe0904082253i119f8660y6a73835a163394f5@mail.gmail.com>
On Thursday 09 April 2009, Kevin Cernekee wrote:
>
> 1) Move the MEMREADOOB/MEMWRITEOOB compat_ioctl wrappers from
> fs/compat_ioctl.c into mtdchar.c . Original request was here:
>
> http://lkml.org/lkml/2009/4/1/295
Very nice cleanup, thanks for doing this!
> 2) Add missing COMPATIBLE_IOCTL lines, so that mtd-utils does not error
> out when running in 64/32 compatibility mode.
This looks correct, but I think it would be better to just remove all
those lines from fs/compat_ioctl.c and add a default: statement in
mtd_compat_ioctl that calls mtd_ioctl for all ioctl numbers that
don't have an explicit handler.
Arnd <><
next prev parent reply other threads:[~2009-04-14 14:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 5:53 [PATCH 3/4] [MTD] compat_ioctl cleanup Kevin Cernekee
2009-04-09 5:53 ` Kevin Cernekee
2009-04-14 14:43 ` Arnd Bergmann [this message]
2009-04-14 14:43 ` Arnd Bergmann
2009-05-29 15:04 ` David Woodhouse
2009-05-29 15:04 ` David Woodhouse
2009-05-29 15:12 ` David Woodhouse
2009-05-29 15:12 ` David Woodhouse
2009-05-29 14:58 ` David Woodhouse
2009-05-29 14:58 ` David Woodhouse
2009-05-29 15:02 ` Arnd Bergmann
2009-05-29 15:02 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904141643.48345.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=adrian.hunter@nokia.com \
--cc=dwmw2@infradead.org \
--cc=kpc.mtd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.