From: Arnd Bergmann <arnd@arndb.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Linux MTD <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH 3/4] [MTD] compat_ioctl cleanup
Date: Fri, 29 May 2009 16:02:36 +0100 [thread overview]
Message-ID: <200905291602.37190.arnd@arndb.de> (raw)
In-Reply-To: <1243609086.19886.179.camel@macbook.infradead.org>
On Friday 29 May 2009, David Woodhouse wrote:
> On Wed, 2009-04-08 at 22:53 -0700, Kevin Cernekee wrote:
> >
> > +static long mtd_compat_ioctl(struct file *file, unsigned int cmd,
> > + unsigned long arg)
> > +{
> > + struct mtd_file_info *mfi = file->private_data;
> > + struct mtd_info *mtd = mfi->mtd;
> > + void __user *argp = (void __user *)arg;
>
> Shouldn't that be 'argp = compat_ptr(arg)' ?
Yes, that's right. I missed this when I looked at the patches.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Kevin Cernekee <kpc.mtd@gmail.com>,
Adrian Hunter <adrian.hunter@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MTD <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 3/4] [MTD] compat_ioctl cleanup
Date: Fri, 29 May 2009 16:02:36 +0100 [thread overview]
Message-ID: <200905291602.37190.arnd@arndb.de> (raw)
In-Reply-To: <1243609086.19886.179.camel@macbook.infradead.org>
On Friday 29 May 2009, David Woodhouse wrote:
> On Wed, 2009-04-08 at 22:53 -0700, Kevin Cernekee wrote:
> >
> > +static long mtd_compat_ioctl(struct file *file, unsigned int cmd,
> > + unsigned long arg)
> > +{
> > + struct mtd_file_info *mfi = file->private_data;
> > + struct mtd_info *mtd = mfi->mtd;
> > + void __user *argp = (void __user *)arg;
>
> Shouldn't that be 'argp = compat_ptr(arg)' ?
Yes, that's right. I missed this when I looked at the patches.
Arnd <><
next prev parent reply other threads:[~2009-05-29 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 5:53 [PATCH 3/4] [MTD] compat_ioctl cleanup Kevin Cernekee
2009-04-09 5:53 ` Kevin Cernekee
2009-04-14 14:43 ` Arnd Bergmann
2009-04-14 14:43 ` Arnd Bergmann
2009-05-29 15:04 ` David Woodhouse
2009-05-29 15:04 ` David Woodhouse
2009-05-29 15:12 ` David Woodhouse
2009-05-29 15:12 ` David Woodhouse
2009-05-29 14:58 ` David Woodhouse
2009-05-29 14:58 ` David Woodhouse
2009-05-29 15:02 ` Arnd Bergmann [this message]
2009-05-29 15:02 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905291602.37190.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=adrian.hunter@nokia.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.