* [lm-sensors] Please,
@ 2009-04-27 11:21 Didier Roche
2009-04-28 9:12 ` Andre Prendel
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Didier Roche @ 2009-04-27 11:21 UTC (permalink / raw)
To: lm-sensors
Hi lm-sensors developer,
It would be great if lm-sensors can take into account distribution
LDFLAGS so that exported variables change linker behavior.
For instance, ubuntu uses -Wl,-Bsymbolic-functions. Taking this patch
will enable us to just sync from debian on this package.
In Ubuntu, we've applied the attached patch to achieve the following:
* handle default ubuntu LDFLAGS for linking option (LP: #321632)
- Remove the old hack directly pushed in lib/Module.mk (now
lib/Module.mk if from pristine source)
- add debian/patches/07-use-LDFLAGS.patch to take LDFLAGS into account
Debian and Ubuntu thought you might be interested to handle this
directly upstream.
--- lm-sensors-3-3.0.2.orig/lib/Module.mk 2008-05-18
8:07:48.000000000 +0200
+++ lm-sensors-3-3.0.2/lib/Module.mk 2009-01-26 22:15:02.000000000 +0100
@@ -60,7 +60,7 @@
# How to create the shared library
$(MODULE_DIR)/$(LIBSHLIBNAME): $(LIBSHOBJECTS)
- $(CC) -shared -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
+ $(CC) -shared $(LDFLAGS) -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
$(MODULE_DIR)/$(LIBSHSONAME): $(MODULE_DIR)/$(LIBSHLIBNAME)
$(RM) $@
Thanks in advance. Please CC me as I'm not subscribed to the mailing list.
Didier
Ubuntu bug: https://bugs.edge.launchpad.net/debian/+source/lm-sensors-3/+bug/321632
Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bugQ3171
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [lm-sensors] Please,
2009-04-27 11:21 [lm-sensors] Please, Didier Roche
@ 2009-04-28 9:12 ` Andre Prendel
2009-04-28 10:11 ` Jean Delvare
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Andre Prendel @ 2009-04-28 9:12 UTC (permalink / raw)
To: lm-sensors
On Mon, Apr 27, 2009 at 01:21:58PM +0200, Didier Roche wrote:
> Hi lm-sensors developer,
>
> It would be great if lm-sensors can take into account distribution
> LDFLAGS so that exported variables change linker behavior.
>
> For instance, ubuntu uses -Wl,-Bsymbolic-functions. Taking this patch
> will enable us to just sync from debian on this package.
>
> In Ubuntu, we've applied the attached patch to achieve the following:
>
> * handle default ubuntu LDFLAGS for linking option (LP: #321632)
> - Remove the old hack directly pushed in lib/Module.mk (now
> lib/Module.mk if from pristine source)
> - add debian/patches/07-use-LDFLAGS.patch to take LDFLAGS into account
>
> Debian and Ubuntu thought you might be interested to handle this
> directly upstream.
>
>
> --- lm-sensors-3-3.0.2.orig/lib/Module.mk 2008-05-18
> 8:07:48.000000000 +0200
> +++ lm-sensors-3-3.0.2/lib/Module.mk 2009-01-26 22:15:02.000000000 +0100
> @@ -60,7 +60,7 @@
>
> # How to create the shared library
> $(MODULE_DIR)/$(LIBSHLIBNAME): $(LIBSHOBJECTS)
> - $(CC) -shared -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
> + $(CC) -shared $(LDFLAGS) -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
>
> $(MODULE_DIR)/$(LIBSHSONAME): $(MODULE_DIR)/$(LIBSHLIBNAME)
> $(RM) $@
>
>
Jean, your'e more familiar with the build system. Any objections? If
no, I will apply this patch.
Andre
> Thanks in advance. Please CC me as I'm not subscribed to the mailing list.
> Didier
>
> Ubuntu bug: https://bugs.edge.launchpad.net/debian/+source/lm-sensors-3/+bug/321632
> Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bugQ3171
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [lm-sensors] Please,
2009-04-27 11:21 [lm-sensors] Please, Didier Roche
2009-04-28 9:12 ` Andre Prendel
@ 2009-04-28 10:11 ` Jean Delvare
2009-04-28 11:57 ` Andre Prendel
2009-04-28 13:00 ` Didier Roche
3 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2009-04-28 10:11 UTC (permalink / raw)
To: lm-sensors
Hi Andre, Didier,
On Tue, 28 Apr 2009 11:12:49 +0200, Andre Prendel wrote:
> On Mon, Apr 27, 2009 at 01:21:58PM +0200, Didier Roche wrote:
> > Hi lm-sensors developer,
> >
> > It would be great if lm-sensors can take into account distribution
> > LDFLAGS so that exported variables change linker behavior.
> >
> > For instance, ubuntu uses -Wl,-Bsymbolic-functions. Taking this patch
> > will enable us to just sync from debian on this package.
> >
> > In Ubuntu, we've applied the attached patch to achieve the following:
> >
> > * handle default ubuntu LDFLAGS for linking option (LP: #321632)
> > - Remove the old hack directly pushed in lib/Module.mk (now
> > lib/Module.mk if from pristine source)
> > - add debian/patches/07-use-LDFLAGS.patch to take LDFLAGS into account
> >
> > Debian and Ubuntu thought you might be interested to handle this
> > directly upstream.
> >
> >
> > --- lm-sensors-3-3.0.2.orig/lib/Module.mk 2008-05-18
> > 8:07:48.000000000 +0200
> > +++ lm-sensors-3-3.0.2/lib/Module.mk 2009-01-26 22:15:02.000000000 +0100
> > @@ -60,7 +60,7 @@
> >
> > # How to create the shared library
> > $(MODULE_DIR)/$(LIBSHLIBNAME): $(LIBSHOBJECTS)
> > - $(CC) -shared -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
> > + $(CC) -shared $(LDFLAGS) -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
> >
> > $(MODULE_DIR)/$(LIBSHSONAME): $(MODULE_DIR)/$(LIBSHLIBNAME)
> > $(RM) $@
> >
> >
>
> Jean, your'e more familiar with the build system. Any objections? If
> no, I will apply this patch.
No objection, if distributions need this, this doesn't cost us a thing,
so just go ahead.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [lm-sensors] Please,
2009-04-27 11:21 [lm-sensors] Please, Didier Roche
2009-04-28 9:12 ` Andre Prendel
2009-04-28 10:11 ` Jean Delvare
@ 2009-04-28 11:57 ` Andre Prendel
2009-04-28 13:00 ` Didier Roche
3 siblings, 0 replies; 5+ messages in thread
From: Andre Prendel @ 2009-04-28 11:57 UTC (permalink / raw)
To: lm-sensors
On Mon, Apr 27, 2009 at 01:21:58PM +0200, Didier Roche wrote:
> Hi lm-sensors developer,
>
> It would be great if lm-sensors can take into account distribution
> LDFLAGS so that exported variables change linker behavior.
>
> For instance, ubuntu uses -Wl,-Bsymbolic-functions. Taking this patch
> will enable us to just sync from debian on this package.
>
> In Ubuntu, we've applied the attached patch to achieve the following:
>
> * handle default ubuntu LDFLAGS for linking option (LP: #321632)
> - Remove the old hack directly pushed in lib/Module.mk (now
> lib/Module.mk if from pristine source)
> - add debian/patches/07-use-LDFLAGS.patch to take LDFLAGS into account
>
> Debian and Ubuntu thought you might be interested to handle this
> directly upstream.
>
>
> --- lm-sensors-3-3.0.2.orig/lib/Module.mk 2008-05-18
> 8:07:48.000000000 +0200
> +++ lm-sensors-3-3.0.2/lib/Module.mk 2009-01-26 22:15:02.000000000 +0100
> @@ -60,7 +60,7 @@
>
> # How to create the shared library
> $(MODULE_DIR)/$(LIBSHLIBNAME): $(LIBSHOBJECTS)
> - $(CC) -shared -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
> + $(CC) -shared $(LDFLAGS) -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
>
> $(MODULE_DIR)/$(LIBSHSONAME): $(MODULE_DIR)/$(LIBSHLIBNAME)
> $(RM) $@
>
>
> Thanks in advance. Please CC me as I'm not subscribed to the mailing list.
> Didier
>
> Ubuntu bug: https://bugs.edge.launchpad.net/debian/+source/lm-sensors-3/+bug/321632
> Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bugQ3171
>
Applied, thanks.
Andre
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [lm-sensors] Please,
2009-04-27 11:21 [lm-sensors] Please, Didier Roche
` (2 preceding siblings ...)
2009-04-28 11:57 ` Andre Prendel
@ 2009-04-28 13:00 ` Didier Roche
3 siblings, 0 replies; 5+ messages in thread
From: Didier Roche @ 2009-04-28 13:00 UTC (permalink / raw)
To: lm-sensors
On Tue, Apr 28, 2009 at 1:57 PM, Andre Prendel <andre_prendel@gmx.de> wrote:
> On Mon, Apr 27, 2009 at 01:21:58PM +0200, Didier Roche wrote:
>> Hi lm-sensors developer,
>>
>> It would be great if lm-sensors can take into account distribution
>> LDFLAGS so that exported variables change linker behavior.
>>
>> For instance, ubuntu uses -Wl,-Bsymbolic-functions. Taking this patch
>> will enable us to just sync from debian on this package.
>>
>> In Ubuntu, we've applied the attached patch to achieve the following:
>>
>> * handle default ubuntu LDFLAGS for linking option (LP: #321632)
>> - Remove the old hack directly pushed in lib/Module.mk (now
>> lib/Module.mk if from pristine source)
>> - add debian/patches/07-use-LDFLAGS.patch to take LDFLAGS into account
>>
>> Debian and Ubuntu thought you might be interested to handle this
>> directly upstream.
>>
>>
>> --- lm-sensors-3-3.0.2.orig/lib/Module.mk 2008-05-18
>> 8:07:48.000000000 +0200
>> +++ lm-sensors-3-3.0.2/lib/Module.mk 2009-01-26 22:15:02.000000000 +0100
>> @@ -60,7 +60,7 @@
>>
>> # How to create the shared library
>> $(MODULE_DIR)/$(LIBSHLIBNAME): $(LIBSHOBJECTS)
>> - $(CC) -shared -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
>> + $(CC) -shared $(LDFLAGS) -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
>>
>> $(MODULE_DIR)/$(LIBSHSONAME): $(MODULE_DIR)/$(LIBSHLIBNAME)
>> $(RM) $@
>>
>>
>> Thanks in advance. Please CC me as I'm not subscribed to the mailing list.
>> Didier
>>
>> Ubuntu bug: https://bugs.edge.launchpad.net/debian/+source/lm-sensors-3/+bug/321632
>> Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bugQ3171
>>
>
> Applied, thanks.
Thanks to YOU :)
It's a pleasure to work with a responsive upstream!
Didier
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-04-28 13:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-27 11:21 [lm-sensors] Please, Didier Roche
2009-04-28 9:12 ` Andre Prendel
2009-04-28 10:11 ` Jean Delvare
2009-04-28 11:57 ` Andre Prendel
2009-04-28 13:00 ` Didier Roche
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.