From: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’
Date: Thu, 30 Apr 2009 09:04:30 +0300 [thread overview]
Message-ID: <20090430060430.GA6040@localhost> (raw)
Trivial: fixing gcc 4.4 compiler warning:
drivers/scsi/st.c: In function ‘st_int_ioctl’:
drivers/scsi/st.c:2967: warning: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
---
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index eb24efe..2bde8a5 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -2964,7 +2964,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon
!(STp->use_pf & PF_TESTED)) {
/* Try the other possible state of Page Format if not
already tried */
- STp->use_pf = !STp->use_pf | PF_TESTED;
+ STp->use_pf = (!STp->use_pf) | PF_TESTED;
st_release_request(SRpnt);
SRpnt = NULL;
return st_int_ioctl(STp, cmd_in, arg);
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2009-04-30 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 6:04 Sergey Senozhatsky [this message]
2009-04-30 21:31 ` [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’ James Bottomley
2009-04-30 21:46 ` Andrew Morton
2009-04-30 21:59 ` Sergey Senozhatsky
2009-04-30 22:08 ` James Bottomley
2009-04-30 22:26 ` [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ???!??? Al Viro
2009-04-30 23:09 ` Sergey Senozhatsky
2009-05-01 5:09 ` Kai Makisara
2009-05-02 5:49 ` [PATCH] SCSI tape: fix gcc 4.4 warning Kai Makisara
-- strict thread matches above, loose matches on Subject: below --
2009-04-30 6:06 [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’ Sergey Senozhatsky
2009-05-01 16:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090430060430.GA6040@localhost \
--to=sergey.senozhatsky@mail.by \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.