From: Al Viro <viro@ZenIV.linux.org.uk>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@mail.by>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi@vger.kernel.org,
Kai Makisara <Kai.Makisara@kolumbus.fi>
Subject: Re: [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ???!???
Date: Thu, 30 Apr 2009 23:26:42 +0100 [thread overview]
Message-ID: <20090430222642.GP8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1241129324.3320.21.camel@mulgrave.int.hansenpartnership.com>
On Thu, Apr 30, 2009 at 10:08:44PM +0000, James Bottomley wrote:
> Well, I know why (!STp->use_pf) is wrong: it would set USE_PF in an
> incredibly obscure fashon. The flag PF_TESTED seems to imply that it's
> a don't check this again type deal, and the if clause is looking for it
> not being set, hence I think the most likely thing to be done here is
> set the PF_TESTED flag.
Not _set_ USE_PF; what's happening there is
^= USE_PF | PF_TESTED; /* we know that PF_TESTED was not set */
next prev parent reply other threads:[~2009-04-30 22:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 6:04 [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’ Sergey Senozhatsky
2009-04-30 21:31 ` James Bottomley
2009-04-30 21:46 ` Andrew Morton
2009-04-30 21:59 ` Sergey Senozhatsky
2009-04-30 22:08 ` James Bottomley
2009-04-30 22:26 ` Al Viro [this message]
2009-04-30 23:09 ` [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ???!??? Sergey Senozhatsky
2009-05-01 5:09 ` Kai Makisara
2009-05-02 5:49 ` [PATCH] SCSI tape: fix gcc 4.4 warning Kai Makisara
-- strict thread matches above, loose matches on Subject: below --
2009-04-30 6:06 [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’ Sergey Senozhatsky
2009-05-01 16:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090430222642.GP8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Kai.Makisara@kolumbus.fi \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sergey.senozhatsky@mail.by \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.