From: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org
Subject: [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’
Date: Thu, 30 Apr 2009 09:06:16 +0300 [thread overview]
Message-ID: <20090430060616.GB6040@localhost> (raw)
Trivial: fixing gcc 4.4 compiler warning:
drivers/net/cxgb3/t3_hw.c: In function ‘t3_prep_adapter’:
drivers/net/cxgb3/t3_hw.c:3782: warning: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
---
diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net/cxgb3/t3_hw.c
index e1bd690..4f68aeb 100644
--- a/drivers/net/cxgb3/t3_hw.c
+++ b/drivers/net/cxgb3/t3_hw.c
@@ -3779,7 +3779,7 @@ int t3_prep_adapter(struct adapter *adapter, const struct adapter_info *ai,
adapter->params.info = ai;
adapter->params.nports = ai->nports0 + ai->nports1;
- adapter->params.chan_map = !!ai->nports0 | (!!ai->nports1 << 1);
+ adapter->params.chan_map = (!!ai->nports0) | (!!ai->nports1 << 1);
adapter->params.rev = t3_read_reg(adapter, A_PL_REV);
/*
* We used to only run the "adapter check task" once a second if
next reply other threads:[~2009-04-30 19:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 6:06 Sergey Senozhatsky [this message]
2009-05-01 16:15 ` [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’ David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-04-30 6:04 Sergey Senozhatsky
2009-04-30 21:31 ` James Bottomley
2009-04-30 21:46 ` Andrew Morton
2009-04-30 21:59 ` Sergey Senozhatsky
2009-04-30 22:08 ` James Bottomley
2009-04-30 22:26 ` [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ???!??? Al Viro
2009-04-30 23:09 ` Sergey Senozhatsky
2009-05-01 5:09 ` Kai Makisara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090430060616.GB6040@localhost \
--to=sergey.senozhatsky@mail.by \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.