From: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
To: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
David Brownell
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH 7/9] spi_mpc83xx: Remove dead code
Date: Fri, 1 May 2009 03:48:30 +0400 [thread overview]
Message-ID: <20090430234830.GG7901@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090430234739.GA27709-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
This patch removes #if 0'ed code, and spi_mpc83xx->busy variable that
is used by that dead snippet only.
Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
---
drivers/spi/spi_mpc83xx.c | 16 ----------------
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
index 50112a5..4192ce4 100644
--- a/drivers/spi/spi_mpc83xx.c
+++ b/drivers/spi/spi_mpc83xx.c
@@ -98,8 +98,6 @@ struct mpc83xx_spi {
bool qe_mode;
- u8 busy;
-
struct workqueue_struct *workqueue;
struct work_struct work;
@@ -411,7 +409,6 @@ static void mpc83xx_spi_work(struct work_struct *work)
work);
spin_lock_irq(&mpc83xx_spi->lock);
- mpc83xx_spi->busy = 1;
while (!list_empty(&mpc83xx_spi->queue)) {
struct spi_message *m = container_of(mpc83xx_spi->queue.next,
struct spi_message, queue);
@@ -423,7 +420,6 @@ static void mpc83xx_spi_work(struct work_struct *work)
spin_lock_irq(&mpc83xx_spi->lock);
}
- mpc83xx_spi->busy = 0;
spin_unlock_irq(&mpc83xx_spi->lock);
}
@@ -482,18 +478,6 @@ static int mpc83xx_spi_setup(struct spi_device *spi)
dev_dbg(&spi->dev, "%s, mode %d, %u bits/w, %u Hz\n",
__func__, spi->mode & (SPI_CPOL | SPI_CPHA),
spi->bits_per_word, spi->max_speed_hz);
-#if 0 /* Don't think this is needed */
- /* NOTE we _need_ to call chipselect() early, ideally with adapter
- * setup, unless the hardware defaults cooperate to avoid confusion
- * between normal (active low) and inverted chipselects.
- */
-
- /* deselect chip (low or high) */
- spin_lock(&mpc83xx_spi->lock);
- if (!mpc83xx_spi->busy)
- mpc83xx_spi_chipselect(spi, BITBANG_CS_INACTIVE);
- spin_unlock(&mpc83xx_spi->lock);
-#endif
return 0;
}
--
1.6.2.2
------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations
Conference from O'Reilly Media. Velocity features a full day of
expert-led, hands-on workshops and two days of sessions from industry
leaders in dedicated Performance & Operations tracks. Use code vel09scf
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
David Brownell <dbrownell@users.sourceforge.net>,
linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net
Subject: [PATCH 7/9] spi_mpc83xx: Remove dead code
Date: Fri, 1 May 2009 03:48:30 +0400 [thread overview]
Message-ID: <20090430234830.GG7901@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090430234739.GA27709@oksana.dev.rtsoft.ru>
This patch removes #if 0'ed code, and spi_mpc83xx->busy variable that
is used by that dead snippet only.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/spi/spi_mpc83xx.c | 16 ----------------
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
index 50112a5..4192ce4 100644
--- a/drivers/spi/spi_mpc83xx.c
+++ b/drivers/spi/spi_mpc83xx.c
@@ -98,8 +98,6 @@ struct mpc83xx_spi {
bool qe_mode;
- u8 busy;
-
struct workqueue_struct *workqueue;
struct work_struct work;
@@ -411,7 +409,6 @@ static void mpc83xx_spi_work(struct work_struct *work)
work);
spin_lock_irq(&mpc83xx_spi->lock);
- mpc83xx_spi->busy = 1;
while (!list_empty(&mpc83xx_spi->queue)) {
struct spi_message *m = container_of(mpc83xx_spi->queue.next,
struct spi_message, queue);
@@ -423,7 +420,6 @@ static void mpc83xx_spi_work(struct work_struct *work)
spin_lock_irq(&mpc83xx_spi->lock);
}
- mpc83xx_spi->busy = 0;
spin_unlock_irq(&mpc83xx_spi->lock);
}
@@ -482,18 +478,6 @@ static int mpc83xx_spi_setup(struct spi_device *spi)
dev_dbg(&spi->dev, "%s, mode %d, %u bits/w, %u Hz\n",
__func__, spi->mode & (SPI_CPOL | SPI_CPHA),
spi->bits_per_word, spi->max_speed_hz);
-#if 0 /* Don't think this is needed */
- /* NOTE we _need_ to call chipselect() early, ideally with adapter
- * setup, unless the hardware defaults cooperate to avoid confusion
- * between normal (active low) and inverted chipselects.
- */
-
- /* deselect chip (low or high) */
- spin_lock(&mpc83xx_spi->lock);
- if (!mpc83xx_spi->busy)
- mpc83xx_spi_chipselect(spi, BITBANG_CS_INACTIVE);
- spin_unlock(&mpc83xx_spi->lock);
-#endif
return 0;
}
--
1.6.2.2
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Brownell <dbrownell@users.sourceforge.net>,
linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH 7/9] spi_mpc83xx: Remove dead code
Date: Fri, 1 May 2009 03:48:30 +0400 [thread overview]
Message-ID: <20090430234830.GG7901@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090430234739.GA27709@oksana.dev.rtsoft.ru>
This patch removes #if 0'ed code, and spi_mpc83xx->busy variable that
is used by that dead snippet only.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/spi/spi_mpc83xx.c | 16 ----------------
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
index 50112a5..4192ce4 100644
--- a/drivers/spi/spi_mpc83xx.c
+++ b/drivers/spi/spi_mpc83xx.c
@@ -98,8 +98,6 @@ struct mpc83xx_spi {
bool qe_mode;
- u8 busy;
-
struct workqueue_struct *workqueue;
struct work_struct work;
@@ -411,7 +409,6 @@ static void mpc83xx_spi_work(struct work_struct *work)
work);
spin_lock_irq(&mpc83xx_spi->lock);
- mpc83xx_spi->busy = 1;
while (!list_empty(&mpc83xx_spi->queue)) {
struct spi_message *m = container_of(mpc83xx_spi->queue.next,
struct spi_message, queue);
@@ -423,7 +420,6 @@ static void mpc83xx_spi_work(struct work_struct *work)
spin_lock_irq(&mpc83xx_spi->lock);
}
- mpc83xx_spi->busy = 0;
spin_unlock_irq(&mpc83xx_spi->lock);
}
@@ -482,18 +478,6 @@ static int mpc83xx_spi_setup(struct spi_device *spi)
dev_dbg(&spi->dev, "%s, mode %d, %u bits/w, %u Hz\n",
__func__, spi->mode & (SPI_CPOL | SPI_CPHA),
spi->bits_per_word, spi->max_speed_hz);
-#if 0 /* Don't think this is needed */
- /* NOTE we _need_ to call chipselect() early, ideally with adapter
- * setup, unless the hardware defaults cooperate to avoid confusion
- * between normal (active low) and inverted chipselects.
- */
-
- /* deselect chip (low or high) */
- spin_lock(&mpc83xx_spi->lock);
- if (!mpc83xx_spi->busy)
- mpc83xx_spi_chipselect(spi, BITBANG_CS_INACTIVE);
- spin_unlock(&mpc83xx_spi->lock);
-#endif
return 0;
}
--
1.6.2.2
next prev parent reply other threads:[~2009-04-30 23:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 23:47 [PATCH 0/9] Some work for spi_mpc83xx driver, spi-mmc support for MPC8610HPCD Anton Vorontsov
2009-04-30 23:47 ` Anton Vorontsov
2009-04-30 23:47 ` Anton Vorontsov
[not found] ` <20090430234739.GA27709-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-04-30 23:48 ` [PATCH 1/9] spi_mpc83xx: Handles other Freescale processors Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` [PATCH 2/9] spi_mpc83xx: Quieten down the "Requested speed is too low" message Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` [PATCH 3/9] spi_mpc83xx: Add small delay after asserting chip-select line Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` [PATCH 4/9] powerpc/86xx: Add MMC SPI support for MPC8610HPCD boards Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` [PATCH 5/9] spi_mpc83xx: Fix checkpatch issues Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` [PATCH 6/9] spi_mpc83xx: Split mpc83xx_spi_work() into two routines Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov [this message]
2009-04-30 23:48 ` [PATCH 7/9] spi_mpc83xx: Remove dead code Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` [PATCH 8/9] spi_mpc83xx: Rename spi_83xx.c to spi_8xxx.c Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` [PATCH 9/9] spi_mpc8xxx: s/83xx/8xxx/g Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-04-30 23:48 ` Anton Vorontsov
2009-05-01 21:42 ` [spi-devel-general] " Grant Likely
2009-05-01 21:42 ` Grant Likely
[not found] ` <20090430234833.GI7901-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-05-04 20:53 ` Andrew Morton
2009-05-04 20:53 ` Andrew Morton
2009-05-04 20:53 ` Andrew Morton
2009-05-04 23:36 ` Anton Vorontsov
2009-05-04 23:36 ` Anton Vorontsov
2009-05-04 20:55 ` [PATCH 0/9] Some work for spi_mpc83xx driver, spi-mmc support for MPC8610HPCD Andrew Morton
2009-05-04 20:55 ` Andrew Morton
[not found] ` <20090504135504.a6a6afcf.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-05-04 23:36 ` Anton Vorontsov
2009-05-04 23:36 ` Anton Vorontsov
2009-05-04 23:36 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090430234830.GG7901@oksana.dev.rtsoft.ru \
--to=avorontsov-hkdhdckh98+b+jhodadfcq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.