From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Jan Kiszka <jan.kiszka@web.de>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 7/8] Introduce reset notifier order
Date: Sat, 2 May 2009 01:34:56 +0100 [thread overview]
Message-ID: <200905020134.56943.paul@codesourcery.com> (raw)
In-Reply-To: <49FB8E33.3040802@web.de>
On Saturday 02 May 2009, Jan Kiszka wrote:
> Paul Brook wrote:
> > On Friday 01 May 2009, Jan Kiszka wrote:
> >> Add the parameter 'order' to qemu_register_reset and sort callbacks on
> >> registration. On system reset, callbacks with lower order will be
> >> invoked before those with higher order. Update all existing users to the
> >> standard order 0.
> >>
> >> Note: At least for x86, the existing users seem to assume that handlers
> >> are called in their registration order. Therefore, the patch preserves
> >> this property. If someone feels bored, (s)he could try to identify this
> >> dependency and express it properly on callback registration.
> >
> > Why do we need this? Why isn't creation order good enough?
>
> At latest when properly deregistering reset handlers again on device
> unplug, the registration order is no longer a static thing, manifested
> in the code organization - which can also break due to refactoring, BTW.
I'm afraid I can't make any sense of this. What exactly are you trying to
solve?
Paul
next prev parent reply other threads:[~2009-05-02 0:35 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 21:17 [Qemu-devel] [PATCH 0/8] kvm: Fixes, cleanups and live migration Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 1/8] kvm: Conditionally apply workaround for KVM slot handling bug Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 3/8] kvm: Fix dirty log temporary buffer size Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 2/8] kvm: Introduce kvm_set_migration_log Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 5/8] kvm: Add missing bits to support live migration Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 6/8] kvm: Fix framebuffer dirty log sync Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 4/8] kvm: Rework dirty bitmap synchronization Jan Kiszka
2009-05-03 10:05 ` [Qemu-devel] " Avi Kivity
2009-05-04 8:52 ` Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 7/8] Introduce reset notifier order Jan Kiszka
2009-05-01 23:52 ` Paul Brook
2009-05-02 0:05 ` [Qemu-devel] " Jan Kiszka
2009-05-02 0:34 ` Paul Brook [this message]
2009-05-04 7:45 ` Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 8/8] kvm: Rework VCPU reset Jan Kiszka
2009-05-03 15:58 ` [Qemu-devel] " Avi Kivity
2009-05-04 8:54 ` Jan Kiszka
2009-05-04 9:12 ` Avi Kivity
2009-05-04 9:29 ` Jan Kiszka
2009-05-04 10:01 ` Avi Kivity
2009-05-01 22:30 ` [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration Anthony Liguori
2009-05-01 22:49 ` Anthony Liguori
2009-05-01 22:49 ` Jan Kiszka
2009-05-01 22:40 ` Anthony Liguori
2009-05-01 22:56 ` Jan Kiszka
2009-05-02 8:07 ` Avi Kivity
2009-05-02 7:40 ` Gleb Natapov
2009-05-02 13:50 ` Anthony Liguori
2009-05-02 17:23 ` Gleb Natapov
2009-05-02 19:12 ` Avi Kivity
2009-05-02 20:07 ` Gleb Natapov
2009-05-02 20:09 ` [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and livemigration Anthony Liguori
2009-05-03 5:25 ` Gleb Natapov
2009-05-03 5:57 ` [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration Avi Kivity
2009-05-03 6:05 ` Gleb Natapov
2009-05-03 7:36 ` Avi Kivity
2009-05-03 7:46 ` Gleb Natapov
2009-05-03 7:50 ` Avi Kivity
2009-05-03 7:56 ` Gleb Natapov
2009-05-03 8:01 ` Avi Kivity
2009-05-03 8:35 ` Gleb Natapov
2009-05-01 22:49 ` [Qemu-devel] [PATCH 9/8] kvm: Save/restore TSC counter Jan Kiszka
2009-05-01 22:51 ` [Qemu-devel] " Anthony Liguori
2009-05-01 22:58 ` Jan Kiszka
2009-05-01 23:09 ` Jan Kiszka
2009-05-01 23:18 ` Anthony Liguori
2009-05-02 0:08 ` [Qemu-devel] [PATCH 9/8] kvm: x86: Save/restore KVM-specific CPU states Jan Kiszka
2009-05-02 0:20 ` [Qemu-devel] [PATCH 9/8 v2] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905020134.56943.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.