Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration

[Avi Kivity <avi@redhat.com>]

Gleb Natapov wrote:
>> I don't think it's necessary.  We can record the software interrupt at  
>> the end of the instruction that generated it, and give it higher  
>> priority than a pending external interrupt.  On vmx, decrement RIP and  
>> set entry instruction length = 1 before injection.
>>     
> And get wrong error value when exception happens during soft interrupt
> delivery? I don't like all those tricks. They work only if everything
> happens like you expected and breaks completely when it is not.
>
>   

Er, yes.

>>                                                     On svm, use EVENTINJ  
>> and forget about the instruction length.
>>
>>     
> On SVM we do not re-inject soft int/exception at all, but re-execute the
> offending instruction.
>   

Maybe we should unexecute the software interrupt instruction on Intel 
and get the same effect.

-- 
error compiling committee.c: too many arguments to function