From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 9/8] kvm: Save/restore TSC counter
Date: Sat, 02 May 2009 00:49:37 +0200 [thread overview]
Message-ID: <49FB7C81.80101@web.de> (raw)
In-Reply-To: <20090501211717.24514.23246.stgit@mchn012c.ww002.siemens.net>
This bit was still missing for stable save/restore or migrate. Only KVM
uses CPUState::tsc, so this value was not yet included into the CPU
snapshot.
---
target-i386/cpu.h | 2 +-
target-i386/machine.c | 8 ++++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index c6bca94..538cbb1 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -837,7 +837,7 @@ static inline int cpu_get_time_fast(void)
#define cpu_signal_handler cpu_x86_signal_handler
#define cpu_list x86_cpu_list
-#define CPU_SAVE_VERSION 8
+#define CPU_SAVE_VERSION 9
/* MMU modes definitions */
#define MMU_MODE0_SUFFIX _kernel
diff --git a/target-i386/machine.c b/target-i386/machine.c
index 4fc7335..27aebf4 100644
--- a/target-i386/machine.c
+++ b/target-i386/machine.c
@@ -149,6 +149,8 @@ void cpu_save(QEMUFile *f, void *opaque)
qemu_put_be64s(f, &env->mtrr_var[i].base);
qemu_put_be64s(f, &env->mtrr_var[i].mask);
}
+
+ qemu_put_be64s(f, &env->tsc);
}
#ifdef USE_X86LDOUBLE
@@ -183,8 +185,7 @@ int cpu_load(QEMUFile *f, void *opaque, int version_id)
uint16_t fpus, fpuc, fptag, fpregs_format;
int32_t a20_mask;
- if (version_id != 3 && version_id != 4 && version_id != 5
- && version_id != 6 && version_id != 7 && version_id != 8)
+ if (version_id < 3 || version_id > CPU_SAVE_VERSION)
return -EINVAL;
for(i = 0; i < CPU_NB_REGS; i++)
qemu_get_betls(f, &env->regs[i]);
@@ -328,6 +329,9 @@ int cpu_load(QEMUFile *f, void *opaque, int version_id)
qemu_get_be64s(f, &env->mtrr_var[i].mask);
}
}
+ if (version_id >= 9) {
+ qemu_get_be64s(f, &env->tsc);
+ }
/* XXX: ensure compatiblity for halted bit ? */
/* XXX: compute redundant hflags bits */
next prev parent reply other threads:[~2009-05-01 22:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 21:17 [Qemu-devel] [PATCH 0/8] kvm: Fixes, cleanups and live migration Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 1/8] kvm: Conditionally apply workaround for KVM slot handling bug Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 6/8] kvm: Fix framebuffer dirty log sync Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 5/8] kvm: Add missing bits to support live migration Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 3/8] kvm: Fix dirty log temporary buffer size Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 2/8] kvm: Introduce kvm_set_migration_log Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 4/8] kvm: Rework dirty bitmap synchronization Jan Kiszka
2009-05-03 10:05 ` [Qemu-devel] " Avi Kivity
2009-05-04 8:52 ` Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 7/8] Introduce reset notifier order Jan Kiszka
2009-05-01 23:52 ` Paul Brook
2009-05-02 0:05 ` [Qemu-devel] " Jan Kiszka
2009-05-02 0:34 ` Paul Brook
2009-05-04 7:45 ` Jan Kiszka
2009-05-01 21:17 ` [Qemu-devel] [PATCH 8/8] kvm: Rework VCPU reset Jan Kiszka
2009-05-03 15:58 ` [Qemu-devel] " Avi Kivity
2009-05-04 8:54 ` Jan Kiszka
2009-05-04 9:12 ` Avi Kivity
2009-05-04 9:29 ` Jan Kiszka
2009-05-04 10:01 ` Avi Kivity
2009-05-01 22:30 ` [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration Anthony Liguori
2009-05-01 22:49 ` Anthony Liguori
2009-05-01 22:49 ` Jan Kiszka
2009-05-01 22:40 ` Anthony Liguori
2009-05-01 22:56 ` Jan Kiszka
2009-05-02 8:07 ` Avi Kivity
2009-05-02 7:40 ` Gleb Natapov
2009-05-02 13:50 ` Anthony Liguori
2009-05-02 17:23 ` Gleb Natapov
2009-05-02 19:12 ` Avi Kivity
2009-05-02 20:07 ` Gleb Natapov
2009-05-02 20:09 ` [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and livemigration Anthony Liguori
2009-05-03 5:25 ` Gleb Natapov
2009-05-03 5:57 ` [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration Avi Kivity
2009-05-03 6:05 ` Gleb Natapov
2009-05-03 7:36 ` Avi Kivity
2009-05-03 7:46 ` Gleb Natapov
2009-05-03 7:50 ` Avi Kivity
2009-05-03 7:56 ` Gleb Natapov
2009-05-03 8:01 ` Avi Kivity
2009-05-03 8:35 ` Gleb Natapov
2009-05-01 22:49 ` Jan Kiszka [this message]
2009-05-01 22:51 ` [Qemu-devel] Re: [PATCH 9/8] kvm: Save/restore TSC counter Anthony Liguori
2009-05-01 22:58 ` Jan Kiszka
2009-05-01 23:09 ` Jan Kiszka
2009-05-01 23:18 ` Anthony Liguori
2009-05-02 0:08 ` [Qemu-devel] [PATCH 9/8] kvm: x86: Save/restore KVM-specific CPU states Jan Kiszka
2009-05-02 0:20 ` [Qemu-devel] [PATCH 9/8 v2] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FB7C81.80101@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.