From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "sakoman@gmail.com" <sakoman@gmail.com>,
"anuj.aggarwal@ti.com" <anuj.aggarwal@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"getarunks@gmail.com" <getarunks@gmail.com>
Subject: Re: [PATCH 1/1] ASoC: TWL4030: Wait RAMP_DELAY on headsetl_event: POST_PMD
Date: Tue, 12 May 2009 16:56:25 +0300 [thread overview]
Message-ID: <20090512165625.e9852d18.jhnikula@gmail.com> (raw)
In-Reply-To: <200905121616.08596.peter.ujfalusi@nokia.com>
On Tue, 12 May 2009 16:16:08 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> On Tuesday 12 May 2009 15:21:55 ext Jarkko Nikula wrote:
> > On Tue, 12 May 2009 15:16:40 +0300
> >
> > Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> > > > Looks like the beep is caused by the ramp operation since beep
> > > > is gone in power-down when reverting both of your patches but
> > > > it's still present in power-up.
> > >
> > > But the 'tuck' still there after you have reverted the patches?
> >
> > Yep it was there even it sounds bit more silent when going to longer
> > ramp times. Beep was present only with '109/81/55 ms'.
>
> Now I'm even more confused...
> Without the patches that you have reverted, the ramp delay does not
> matter after the playback. It just cuts the VMID and that's it.
> On startup the ramp is initiated. If you set the ramp delay longer,
> than it is possible that the beginning of the audio is played already
> when the VMID is ramping up.
>
> So with the ramp (down) delay - the patches that you have reverted -
> the 'tuck' was worst after playback, than without the proper ramp
> (down) delay handling?
>
Hopefully I didn't confuse you too much :-)
So with your patches reverted, the low-frequency pop was gone in
power-down since there were no ramp implemented but there still were
the sharp snap. I didn't notice were there any difference on that.
Then this low-frequency pop went more silent as the ramp time
increased. Allways in power-up phase and also in power-down when your
patches were in implementing the ramp down.
Third observation was that the beep was present with ramp time of
'109/81/55 ms'. Without your patches it was present only in power-up
and with your patches is was also in power-down phase. So it sounds to
me that beep was there when the ramp up or down was going.
> I can see on the scope, that the ramp up also has kind of 'tuck'
> problem, but it comes when the VMID is quite low, so it is harder to
> hear it. By making the ramp delay longer, this 'tuck' happens when
> the VMID is close to 0, so it makes it less audible.
>
I think for me this low-frequency power-up and -down (when your
patches are in) pops are caused when the capasitors connected into
HSOL/HSOR are charging/discharging through the headphones.
What I'm wondering how it is possible to hear such a slow ramp like 100
ms?
--
Jarkko
next prev parent reply other threads:[~2009-05-12 13:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 11:14 [PATCH 0/1] ASoC: TWL4030: Headset ramp down fix Peter Ujfalusi
2009-05-11 11:14 ` [PATCH 1/1] ASoC: TWL4030: Wait RAMP_DELAY on headsetl_event: POST_PMD Peter Ujfalusi
2009-05-11 12:03 ` Jarkko Nikula
2009-05-12 10:50 ` Peter Ujfalusi
2009-05-12 11:19 ` Jarkko Nikula
2009-05-12 11:31 ` Peter Ujfalusi
2009-05-12 11:52 ` Jarkko Nikula
2009-05-12 12:02 ` Jarkko Nikula
2009-05-12 12:16 ` Peter Ujfalusi
2009-05-12 12:21 ` Jarkko Nikula
2009-05-12 13:16 ` Peter Ujfalusi
2009-05-12 13:56 ` Jarkko Nikula [this message]
2009-05-13 12:57 ` Peter Ujfalusi
2009-05-13 13:05 ` Mark Brown
2009-05-14 5:27 ` Peter Ujfalusi
2009-05-14 6:08 ` Jarkko Nikula
2009-05-14 6:35 ` Peter Ujfalusi
2009-05-14 8:09 ` Peter Ujfalusi
2009-05-14 9:05 ` Jarkko Nikula
2009-05-14 9:19 ` Peter Ujfalusi
2009-05-14 9:24 ` Mark Brown
2009-05-14 9:48 ` Peter Ujfalusi
2009-05-14 9:56 ` Mark Brown
2009-05-14 12:44 ` Peter Ujfalusi
2009-05-14 12:53 ` [PATCH 1/1] ASoC: TWL4030: Wait RAMP_DELAY?on " Mark Brown
2009-05-15 6:30 ` Peter Ujfalusi
2009-05-18 7:46 ` Peter Ujfalusi
2009-05-14 9:23 ` [PATCH 1/1] ASoC: TWL4030: Wait RAMP_DELAY on " Mark Brown
2009-05-11 12:57 ` [PATCH 0/1] ASoC: TWL4030: Headset ramp down fix Arun KS
2009-05-12 3:59 ` Anuj Aggarwal
2009-05-12 5:33 ` Jarkko Nikula
2009-05-12 6:14 ` Aggarwal, Anuj
2009-05-12 6:39 ` Jarkko Nikula
2009-05-12 6:50 ` Aggarwal, Anuj
2009-05-12 6:44 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512165625.e9852d18.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=anuj.aggarwal@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=getarunks@gmail.com \
--cc=peter.ujfalusi@nokia.com \
--cc=sakoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.