All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "sakoman@gmail.com" <sakoman@gmail.com>,
	"anuj.aggarwal@ti.com" <anuj.aggarwal@ti.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	ext Mark Brown <broonie@opensource.wolfsonmicro.com>,
	"getarunks@gmail.com" <getarunks@gmail.com>
Subject: Re: [PATCH 1/1] ASoC: TWL4030: Wait RAMP_DELAY on headsetl_event: POST_PMD
Date: Thu, 14 May 2009 12:05:50 +0300	[thread overview]
Message-ID: <20090514120550.88494822.jhnikula@gmail.com> (raw)
In-Reply-To: <200905141109.09084.peter.ujfalusi@nokia.com>

On Thu, 14 May 2009 11:09:08 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:

> Startup:
> dac -> HS ramp up (HS enable, fake PGA) -> PGA
> 
> Standby:
> HS ramp down (HS disable, fake PGA) -> PGA -> dac
> 
> If the order of the startup can be somehow altered to be:
> dac -> PGA -> HS ramp up (HS enable, fake PGA)
> 
Did you implement this fake or actually real PGA between "HeadsetL
Mixer" and "HSOL"?

I seems that there is an error in audio path that output pin control is
tied to mixer and there is no widget in audio path defining the output
amplifier. See

SND_SOC_DAPM_MIXER_E("HeadsetL Mixer", SND_SOC_NOPM, 0, 0,
	&twl4030_dapm_hsol_controls[0],
	ARRAY_SIZE(twl4030_dapm_hsol_controls), headsetl_event,
	SND_SOC_DAPM_POST_PMU|SND_SOC_DAPM_POST_PMD),
...
	{"HSOL", NULL, "HeadsetL Mixer"},
	{"HSOR", NULL, "HeadsetR Mixer"},

So startup/shutdown order should be correct if you define a new PGA
between the HSOx and Headsetx mixer and let that to manage output pin
power.


-- 
Jarkko

  reply	other threads:[~2009-05-14  9:04 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 11:14 [PATCH 0/1] ASoC: TWL4030: Headset ramp down fix Peter Ujfalusi
2009-05-11 11:14 ` [PATCH 1/1] ASoC: TWL4030: Wait RAMP_DELAY on headsetl_event: POST_PMD Peter Ujfalusi
2009-05-11 12:03   ` Jarkko Nikula
2009-05-12 10:50     ` Peter Ujfalusi
2009-05-12 11:19       ` Jarkko Nikula
2009-05-12 11:31         ` Peter Ujfalusi
2009-05-12 11:52           ` Jarkko Nikula
2009-05-12 12:02             ` Jarkko Nikula
2009-05-12 12:16               ` Peter Ujfalusi
2009-05-12 12:21                 ` Jarkko Nikula
2009-05-12 13:16                   ` Peter Ujfalusi
2009-05-12 13:56                     ` Jarkko Nikula
2009-05-13 12:57                       ` Peter Ujfalusi
2009-05-13 13:05                         ` Mark Brown
2009-05-14  5:27                           ` Peter Ujfalusi
2009-05-14  6:08                             ` Jarkko Nikula
2009-05-14  6:35                               ` Peter Ujfalusi
2009-05-14  8:09                               ` Peter Ujfalusi
2009-05-14  9:05                                 ` Jarkko Nikula [this message]
2009-05-14  9:19                                   ` Peter Ujfalusi
2009-05-14  9:24                                 ` Mark Brown
2009-05-14  9:48                                   ` Peter Ujfalusi
2009-05-14  9:56                                     ` Mark Brown
2009-05-14 12:44                                       ` Peter Ujfalusi
2009-05-14 12:53                                         ` [PATCH 1/1] ASoC: TWL4030: Wait RAMP_DELAY?on " Mark Brown
2009-05-15  6:30                                           ` Peter Ujfalusi
2009-05-18  7:46                                             ` Peter Ujfalusi
2009-05-14  9:23                             ` [PATCH 1/1] ASoC: TWL4030: Wait RAMP_DELAY on " Mark Brown
2009-05-11 12:57 ` [PATCH 0/1] ASoC: TWL4030: Headset ramp down fix Arun KS
2009-05-12  3:59   ` Anuj Aggarwal
2009-05-12  5:33     ` Jarkko Nikula
2009-05-12  6:14       ` Aggarwal, Anuj
2009-05-12  6:39         ` Jarkko Nikula
2009-05-12  6:50           ` Aggarwal, Anuj
2009-05-12  6:44   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090514120550.88494822.jhnikula@gmail.com \
    --to=jhnikula@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=anuj.aggarwal@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=getarunks@gmail.com \
    --cc=peter.ujfalusi@nokia.com \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.