Re: [PATCH 1/1] ASoC: TWL4030: Wait RAMP_DELAY?on headsetl_event: POST_PMD

[Peter Ujfalusi <peter.ujfalusi@nokia.com>]

On Thursday 14 May 2009 15:53:34 ext Mark Brown wrote:
> On Thu, May 14, 2009 at 03:44:47PM +0300, Peter Ujfalusi wrote:
> > On Thursday 14 May 2009 12:56:21 ext Mark Brown wrote:
> > > The event could check the current setup and do whatever's appropriate?
> >
> > I have to think about this, but at first sight it does look awfully
> > complicated thing to do (4 PGA, 7 output with mixers, 2+1 output mux)...
>
> It might help to have the mixers and muxes maintain some state when they
> change?  It's just a suggestion, I'm not familiar enough with the codec
> to know if it's a sensible one for this device or if it's more trouble
> than it's worth.

I have given this one a though and it might be not that problematic. What I'm 
afraid is that there are some corner cases, which might need some special 
attention.

>
> > I think I don't want to fixate the ramp delay to any value (meaning that
> > the delay would last around 50ms). This seams to be also board specific,
> > so I would rather leave this to the user to find the best value for the
> > given board.
>
> Ah, right.  Possibly worth making it platform data, I suppose, but
> that'd be a pain when experimenting to find the values.

In the future I can add platform data for the initial ramp delay value, which 
can be passed from the board file, but still the user will be able to change 
that if he/she wanted to.

-- 
Péter