All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	"riel@redhat.com" <riel@redhat.com>,
	"tytso@mit.edu" <tytso@mit.edu>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"elladan@eskimo.com" <elladan@eskimo.com>,
	"npiggin@suse.de" <npiggin@suse.de>,
	"minchan.kim@gmail.com" <minchan.kim@gmail.com>
Subject: Re: [PATCH 3/3] vmscan: merge duplicate code in shrink_active_list()
Date: Tue, 19 May 2009 12:18:33 +0200	[thread overview]
Message-ID: <20090519101833.GA1872@cmpxchg.org> (raw)
In-Reply-To: <20090519024316.GA7562@localhost>

On Tue, May 19, 2009 at 10:43:16AM +0800, Wu Fengguang wrote:
> @@ -1283,6 +1319,7 @@ static void shrink_active_list(unsigned 
>  			 * are ignored, since JVM can create lots of anon
>  			 * VM_EXEC pages.
>  			 */
> +			if (page_cluster)
>  			if ((vm_flags & VM_EXEC) && !PageAnon(page)) {
>  				list_add(&page->lru, &l_active);
>  				continue;

Huh, what's with that hunk?

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	"riel@redhat.com" <riel@redhat.com>,
	"tytso@mit.edu" <tytso@mit.edu>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"elladan@eskimo.com" <elladan@eskimo.com>,
	"npiggin@suse.de" <npiggin@suse.de>,
	"minchan.kim@gmail.com" <minchan.kim@gmail.com>
Subject: Re: [PATCH 3/3] vmscan: merge duplicate code in shrink_active_list()
Date: Tue, 19 May 2009 12:18:33 +0200	[thread overview]
Message-ID: <20090519101833.GA1872@cmpxchg.org> (raw)
In-Reply-To: <20090519024316.GA7562@localhost>

On Tue, May 19, 2009 at 10:43:16AM +0800, Wu Fengguang wrote:
> @@ -1283,6 +1319,7 @@ static void shrink_active_list(unsigned 
>  			 * are ignored, since JVM can create lots of anon
>  			 * VM_EXEC pages.
>  			 */
> +			if (page_cluster)
>  			if ((vm_flags & VM_EXEC) && !PageAnon(page)) {
>  				list_add(&page->lru, &l_active);
>  				continue;

Huh, what's with that hunk?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-05-19 10:18 UTC|newest]

Thread overview: 195+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-17  2:23 [PATCH 0/3] make mapped executable pages the first class citizen Wu Fengguang
2009-05-17  2:23 ` Wu Fengguang
2009-05-17  2:23 ` [PATCH 1/3] vmscan: report vm_flags in page_referenced() Wu Fengguang
2009-05-17  2:23   ` Wu Fengguang
2009-05-17  2:23 ` [PATCH 2/3] vmscan: make mapped executable pages the first class citizen Wu Fengguang
2009-05-17  2:23   ` Wu Fengguang
2009-05-19  8:59   ` Wu Fengguang
2009-05-19  8:59     ` Wu Fengguang
2009-05-17  2:23 ` [PATCH 3/3] vmscan: merge duplicate code in shrink_active_list() Wu Fengguang
2009-05-17  2:23   ` Wu Fengguang
2009-05-18  9:16   ` Wu Fengguang
2009-05-18  9:16     ` Wu Fengguang
2009-05-19  2:43     ` Wu Fengguang
2009-05-19  2:43       ` Wu Fengguang
2009-05-19 10:18       ` Johannes Weiner [this message]
2009-05-19 10:18         ` Johannes Weiner
2009-05-19 10:32         ` Wu Fengguang
2009-05-19 10:32           ` Wu Fengguang
2009-06-18 14:46 ` [PATCH 0/3] make mapped executable pages the first class citizen David Howells
2009-06-18 14:46   ` David Howells
2009-06-18 14:51   ` David Howells
2009-06-18 14:51     ` David Howells
2009-06-18 16:18   ` David Howells
2009-06-18 16:18     ` David Howells
2009-06-18 16:57     ` Andrew Morton
2009-06-18 16:57       ` Andrew Morton
2009-06-20  4:33       ` Wu Fengguang
2009-06-20  4:33         ` Wu Fengguang
2009-06-20  8:24         ` David Howells
2009-06-20  8:24           ` David Howells
2009-06-23 14:43         ` David Howells
2009-06-23 14:43           ` David Howells
2009-06-24  1:43           ` KOSAKI Motohiro
2009-06-24  1:43             ` KOSAKI Motohiro
2009-06-24  2:32           ` Wu Fengguang
2009-06-24  2:32             ` Wu Fengguang
2009-06-24  2:43             ` KOSAKI Motohiro
2009-06-24  2:43               ` KOSAKI Motohiro
2009-06-24  2:49               ` Wu Fengguang
2009-06-24  2:49                 ` Wu Fengguang
2009-06-27 11:53               ` Johannes Weiner
2009-06-27 11:53                 ` Johannes Weiner
2009-06-27 18:40                 ` David Howells
2009-06-27 18:40                   ` David Howells
2009-06-24 13:07             ` David Howells
2009-06-24 13:07               ` David Howells
2009-06-27  7:12               ` Found the commit that causes the OOMs David Howells
2009-06-27  7:12                 ` David Howells
2009-06-27 12:07                 ` Minchan Kim
2009-06-27 12:07                   ` Minchan Kim
2009-06-27 18:58                   ` David Howells
2009-06-27 18:58                     ` David Howells
2009-06-27 12:54                 ` Johannes Weiner
2009-06-27 12:54                   ` Johannes Weiner
2009-06-27 13:50                   ` Minchan Kim
2009-06-27 13:50                     ` Minchan Kim
2009-06-27 15:36                     ` Johannes Weiner
2009-06-27 15:36                       ` Johannes Weiner
2009-06-28 16:53                       ` Minchan Kim
2009-06-28 16:53                         ` Minchan Kim
2009-06-27 15:52                   ` KOSAKI Motohiro
2009-06-27 15:52                     ` KOSAKI Motohiro
2009-06-27 18:35                   ` David Howells
2009-06-27 18:35                     ` David Howells
2009-06-28  7:55                   ` David Howells
2009-06-28  7:55                     ` David Howells
2009-06-28 11:32                   ` Wu Fengguang
2009-06-28 11:32                     ` Wu Fengguang
2009-06-28 13:30                     ` Minchan Kim
2009-06-28 13:30                       ` Minchan Kim
2009-06-28 13:36                       ` Minchan Kim
2009-06-28 13:36                         ` Minchan Kim
2009-06-28 14:22                         ` Wu Fengguang
2009-06-28 14:22                           ` Wu Fengguang
2009-06-28 15:01                           ` KOSAKI Motohiro
2009-06-28 15:01                             ` KOSAKI Motohiro
2009-06-28 15:10                             ` Wu Fengguang
2009-06-28 15:10                               ` Wu Fengguang
2009-06-28 16:50                               ` Minchan Kim
2009-06-28 16:50                                 ` Minchan Kim
2009-06-29  0:17                               ` Minchan Kim
2009-06-29  0:17                                 ` Minchan Kim
2009-06-29  7:34                                 ` Wu Fengguang
2009-06-29  7:34                                   ` Wu Fengguang
2009-06-29 10:10                                   ` David Howells
2009-06-29 10:10                                     ` David Howells
2009-06-29 12:55                                     ` Wu Fengguang
2009-06-29 12:55                                       ` Wu Fengguang
2009-06-29 14:21                                       ` David Howells
2009-06-29 14:21                                         ` David Howells
2009-06-29 15:00                                         ` Minchan Kim
2009-06-29 15:00                                           ` Minchan Kim
2009-06-29 15:14                                           ` Wu Fengguang
2009-06-29 15:14                                             ` Wu Fengguang
2009-06-29 15:54                                             ` David Howells
2009-06-29 15:54                                               ` David Howells
2009-06-29 15:56                                               ` David Woodhouse
2009-06-29 15:56                                                 ` David Woodhouse
2009-06-30 14:05                                                 ` Wu Fengguang
2009-06-30 14:05                                                   ` Wu Fengguang
2009-06-30 15:50                                                   ` Minchan Kim
2009-06-30 15:50                                                     ` Minchan Kim
2009-07-01  2:30                                                     ` Wu Fengguang
2009-07-01  2:30                                                       ` Wu Fengguang
2009-07-01  1:18                                                   ` KOSAKI Motohiro
2009-07-01  1:18                                                     ` KOSAKI Motohiro
2009-07-01  2:13                                                     ` Rik van Riel
2009-07-01  2:13                                                       ` Rik van Riel
2009-07-01  2:16                                                     ` Wu Fengguang
2009-07-01  2:16                                                       ` Wu Fengguang
2009-07-01  2:26                                                       ` Wu Fengguang
2009-07-01  2:26                                                         ` Wu Fengguang
2009-07-01  2:51                                                         ` KOSAKI Motohiro
2009-07-01  2:51                                                           ` KOSAKI Motohiro
2009-07-01  2:57                                                           ` Rik van Riel
2009-07-01  2:57                                                             ` Rik van Riel
2009-07-01  4:06                                                             ` Wu Fengguang
2009-07-01  4:06                                                               ` Wu Fengguang
2009-07-01  4:18                                                               ` KOSAKI Motohiro
2009-07-01  4:18                                                                 ` KOSAKI Motohiro
2009-07-01  4:25                                                                 ` Wu Fengguang
2009-07-01  4:25                                                                   ` Wu Fengguang
2009-07-01  4:30                                                                   ` KOSAKI Motohiro
2009-07-01  4:30                                                                     ` KOSAKI Motohiro
2009-07-01 11:27                                                                     ` Wu Fengguang
2009-07-01 11:27                                                                       ` Wu Fengguang
2009-07-05  9:55                                                             ` Wu Fengguang
2009-07-05  9:55                                                               ` Wu Fengguang
2009-07-05 10:38                                                               ` KOSAKI Motohiro
2009-07-05 10:38                                                                 ` KOSAKI Motohiro
2009-07-05 10:51                                                                 ` Wu Fengguang
2009-07-05 10:51                                                                   ` Wu Fengguang
2009-07-01  3:54                                                           ` Wu Fengguang
2009-07-01  3:54                                                             ` Wu Fengguang
2009-06-29 15:27                                           ` David Howells
2009-06-29 15:27                                             ` David Howells
2009-06-29 16:07                                           ` Mel Gorman
2009-06-29 16:07                                             ` Mel Gorman
2009-06-30  4:07                                             ` Minchan Kim
2009-06-30  4:07                                               ` Minchan Kim
2009-06-30  9:22                                               ` Mel Gorman
2009-06-30  9:22                                                 ` Mel Gorman
2009-06-30  9:30                                                 ` Minchan Kim
2009-06-30  9:30                                                   ` Minchan Kim
2009-06-30 14:00                                                 ` Minchan Kim
2009-06-30 14:00                                                   ` Minchan Kim
2009-06-30 19:57                                               ` David Howells
2009-06-30 19:57                                                 ` David Howells
2009-07-02  7:41                                                 ` Minchan Kim
2009-07-02  7:41                                                   ` Minchan Kim
2009-07-02  7:44                                                   ` Minchan Kim
2009-07-02  7:44                                                     ` Minchan Kim
2009-07-02 12:43                                                   ` Wu Fengguang
2009-07-02 12:43                                                     ` Wu Fengguang
2009-07-02 14:08                                                     ` Minchan Kim
2009-07-02 14:08                                                       ` Minchan Kim
2009-06-28 14:49                       ` KOSAKI Motohiro
2009-06-28 14:49                         ` KOSAKI Motohiro
2009-06-28 15:04                         ` Wu Fengguang
2009-06-28 15:04                           ` Wu Fengguang
2009-06-28 16:47                         ` Minchan Kim
2009-06-28 16:47                           ` Minchan Kim
2009-06-29  7:48                           ` KOSAKI Motohiro
2009-06-29  7:48                             ` KOSAKI Motohiro
2009-06-29  9:32                             ` Minchan Kim
2009-06-29  9:32                               ` Minchan Kim
2009-06-29 12:43                             ` David Howells
2009-06-29 12:43                               ` David Howells
2009-06-29 12:59                               ` Wu Fengguang
2009-06-29 12:59                                 ` Wu Fengguang
2009-06-29 16:57                               ` Andrew Morton
2009-06-29 16:57                                 ` Andrew Morton
2009-06-29 18:54                                 ` KOSAKI Motohiro
2009-06-29 18:54                                   ` KOSAKI Motohiro
2009-06-29 19:08                                   ` KOSAKI Motohiro
2009-06-29 19:08                                     ` KOSAKI Motohiro
2009-06-19  5:27     ` [PATCH 0/3] make mapped executable pages the first class citizen Wu Fengguang
2009-06-19  5:27       ` Wu Fengguang
2009-06-19  5:24   ` Wu Fengguang
2009-06-19  5:24     ` Wu Fengguang
2009-06-19  5:58   ` Wu Fengguang
2009-06-19  5:58     ` Wu Fengguang
2009-06-19  8:06     ` David Howells
2009-06-19  8:06       ` David Howells
  -- strict thread matches above, loose matches on Subject: below --
2009-06-08  9:10 [PATCH 0/3] make mapped executable pages the first class citizen (with test cases) Wu Fengguang
2009-06-08  9:10 ` [PATCH 3/3] vmscan: merge duplicate code in shrink_active_list() Wu Fengguang
2009-05-16  9:00 [PATCH 0/3] make mapped executable pages the first class citizen Wu Fengguang
2009-05-16  9:00 ` [PATCH 3/3] vmscan: merge duplicate code in shrink_active_list() Wu Fengguang
2009-05-16  9:00   ` Wu Fengguang
2009-05-16 13:39   ` Johannes Weiner
2009-05-16 13:39     ` Johannes Weiner
2009-05-16 13:47     ` Wu Fengguang
2009-05-16 13:47       ` Wu Fengguang
2009-05-16 14:35   ` Rik van Riel
2009-05-16 14:35     ` Rik van Riel
2009-05-17  1:24   ` Minchan Kim
2009-05-17  1:24     ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090519101833.GA1872@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=elladan@eskimo.com \
    --cc=fengguang.wu@intel.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=npiggin@suse.de \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.