From: Theodore Tso <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] EXT3: Change all super.c messages to print the device
Date: Tue, 19 May 2009 13:49:01 -0400 [thread overview]
Message-ID: <20090519174901.GB9053@mit.edu> (raw)
In-Reply-To: <20090519171430.GA26480@atrey.karlin.mff.cuni.cz>
On Tue, May 19, 2009 at 07:14:30PM +0200, Jan Kara wrote:
> > EXT3: Change all super.c messages to print the device
> >
> > I had a problem where it was unclear to which device a ext3 message belonged.
> > Not all of them them print it.
> >
> > This patch changes ext3 super.c to include the device name with all
> > warning/error messages, by using a new utility function ext3_msg.
> > It's a rather large patch, but very mechanic. I left debug printks
> > alone.
> >
> > The normal mount output looks a little more regular now because near all
> > messages are in the same format.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> Ted, did you pick up this cleanup? I don't see any reply or the patch
> being merged... The cleanup looks nice.
No, I didn't but thanks for reminding me; I agree it's a good cleanup.
We should get it ported over to ext4, too.
- Ted
next prev parent reply other threads:[~2009-05-19 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 18:49 [PATCH] EXT3: Change all super.c messages to print the device Andi Kleen
2009-05-19 17:14 ` Jan Kara
2009-05-19 17:49 ` Theodore Tso [this message]
2009-05-19 18:53 ` Eric Sandeen
2009-05-20 11:21 ` Theodore Tso
2009-05-20 11:30 ` Andi Kleen
2009-05-20 15:50 ` Eric Sandeen
2009-05-20 16:00 ` Andi Kleen
2009-05-20 21:23 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519174901.GB9053@mit.edu \
--to=tytso@mit.edu \
--cc=andi@firstfloor.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.