From: Andi Kleen <andi@firstfloor.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Theodore Tso <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] EXT3: Change all super.c messages to print the device
Date: Wed, 20 May 2009 13:30:47 +0200 [thread overview]
Message-ID: <20090520113047.GC8684@one.firstfloor.org> (raw)
In-Reply-To: <4A130022.6090807@redhat.com>
> I'll do that, unless anyone's already started.
Fine by me. I haven't done anything on it. Ideally ext2 too.
>
> There's a bit of inconsistency in the patch between:
>
> ext3_msg(sb, KERN_ERR "message");
> and
> ext3_msg(sb, KERN_ERR, "message");
>
> just FWIW.
Where?
% grep '^+' ext3-msg | grep 'KERN[_A-Z]+[^,]'
%
The missing comma would probably not compile.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-05-20 11:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 18:49 [PATCH] EXT3: Change all super.c messages to print the device Andi Kleen
2009-05-19 17:14 ` Jan Kara
2009-05-19 17:49 ` Theodore Tso
2009-05-19 18:53 ` Eric Sandeen
2009-05-20 11:21 ` Theodore Tso
2009-05-20 11:30 ` Andi Kleen [this message]
2009-05-20 15:50 ` Eric Sandeen
2009-05-20 16:00 ` Andi Kleen
2009-05-20 21:23 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520113047.GC8684@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.