Re: [PATCH] EXT3: Change all super.c messages to print the device

[Eric Sandeen <sandeen@redhat.com>]

Andi Kleen wrote:
>> Just a one I guess:
>>
>> $ grep '^+' patch | grep 'KERN[_A-Z]\+[ $]'
>> +			ext3_msg(sb, KERN_ERR "(no)acl options not supported");
>> +	printk(KERN_INFO "EXT3-FS (%s): ", sb->s_id);
> 
> Ok thanks. Not sure how grep missed that one
> 
> Here's a updated patch with that fixed.
> 
> ---

Sorry, one more nitpick while I was comparing this to my ext4 patch
doing the same:


> @@ -1465,11 +1473,11 @@
>  #define PLURAL(x) (x), ((x)==1) ? "" : "s"
>  
>  	if (nr_orphans)
> -		printk(KERN_INFO "EXT3-fs: %s: %d orphan inode%s deleted\n",
> -		       sb->s_id, PLURAL(nr_orphans));
> +		ext3_msg(sb, KERN_INFO, "%d orphan inode%s deleted",
> +			PLURAL(nr_orphans));
>  	if (nr_truncates)
> -		printk(KERN_INFO "EXT3-fs: %s: %d truncate%s cleaned up\n",
> -		       sb->s_id, PLURAL(nr_truncates));
> +		ext3_msg(sb, KERN_INFO, "%5d truncate%s cleaned up",
                                         ^^^ I doubt you wanted this :)

-Eric

> +		       PLURAL(nr_truncates));
>  #ifdef CONFIG_QUOTA
>  	/* Turn quotas off */
>  	for (i = 0; i < MAXQUOTAS; i++) {