Re: [PATCH 0/2] Add serial number support for virtio_blk, V2

[Gleb Natapov <gleb@redhat.com>]

On Wed, May 20, 2009 at 03:31:29AM -0400, Christoph Hellwig wrote:
> On Mon, May 18, 2009 at 11:00:41AM -0400, john cooper wrote:
> > Christoph Hellwig wrote:
> >> On Wed, May 13, 2009 at 01:06:57PM -0400, john cooper wrote:
> >>> [Resend of earlier patch: 1/2 rebased to qemu-kvm,
> >>> 2/2 minor tweak]
> >>
> >> patch 1/2 seems to be missing.
> > It is in the kvm and qemu-devel list archives:
> >
> > http://www.spinics.net/lists/kvm/maillist.html
> > http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg00661.html
> 
> Ah, it got posted as reply to the previous submission, not with this
> one.
> 
> >> So why can't we re-use the existing interfaces instead of inventing a
> >> new one?
> > I'm unclear to what specifically you're referring -- the
> > ioctl() used to retrieve the serial number in the guest?
> 
> Well, there's not specific ioctl to get a serial number for scsi, but
> given that we now have SG_IO passthrough in virtio-blk it should be easy
> enough to provide inquiry data and the device identification VPD page
> by that way.  Not sure how it's handled for ide, maybe that way
> is even easier.
> 
IDE has "identify" command which return various info including 20 byte
serial number.

--
			Gleb.