All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>,
	qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>,
	kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
	vi
Subject: [PATCH 08/11] qemu: add support for resizing regions
Date: Mon, 25 May 2009 15:26:05 +0300	[thread overview]
Message-ID: <20090525122605.GI5046@redhat.com> (raw)
In-Reply-To: <cover.1243253205.git.mst@redhat.com>

Make it possible to resize PCI regions.  This will be used by virtio
with MSI-X, where the region size depends on whether MSI-X is enabled,
and can change across load/save.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/pci.c |   54 ++++++++++++++++++++++++++++++++++++------------------
 hw/pci.h |    3 +++
 2 files changed, 39 insertions(+), 18 deletions(-)

diff --git a/hw/pci.c b/hw/pci.c
index 6bc3819..19905b9 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -392,6 +392,41 @@ void pci_register_io_region(PCIDevice *pci_dev, int region_num,
     *(uint32_t *)(pci_dev->mask + addr) = cpu_to_le32(mask);
 }
 
+static void pci_unmap_region(PCIDevice *d, PCIIORegion *r)
+{
+    if (r->addr == -1)
+        return;
+    if (r->type & PCI_ADDRESS_SPACE_IO) {
+        int class;
+        /* NOTE: specific hack for IDE in PC case:
+           only one byte must be mapped. */
+        class = pci_get_word(d->config + PCI_CLASS_DEVICE);
+        if (class == 0x0101 && r->size == 4) {
+            isa_unassign_ioport(r->addr + 2, 1);
+        } else {
+            isa_unassign_ioport(r->addr, r->size);
+        }
+    } else {
+        cpu_register_physical_memory(pci_to_cpu_addr(r->addr),
+                                     r->size,
+                                     IO_MEM_UNASSIGNED);
+        qemu_unregister_coalesced_mmio(r->addr, r->size);
+    }
+}
+
+void pci_resize_io_region(PCIDevice *pci_dev, int region_num,
+                          uint32_t size)
+{
+
+    PCIIORegion *r = &pci_dev->io_regions[region_num];
+    if (r->size == size)
+        return;
+    r->size = size;
+    pci_unmap_region(pci_dev, r);
+    r->addr = -1;
+    pci_update_mappings(pci_dev);
+}
+
 static void pci_update_mappings(PCIDevice *d)
 {
     PCIIORegion *r;
@@ -445,24 +480,7 @@ static void pci_update_mappings(PCIDevice *d)
             }
             /* now do the real mapping */
             if (new_addr != r->addr) {
-                if (r->addr != -1) {
-                    if (r->type & PCI_ADDRESS_SPACE_IO) {
-                        int class;
-                        /* NOTE: specific hack for IDE in PC case:
-                           only one byte must be mapped. */
-                        class = d->config[0x0a] | (d->config[0x0b] << 8);
-                        if (class == 0x0101 && r->size == 4) {
-                            isa_unassign_ioport(r->addr + 2, 1);
-                        } else {
-                            isa_unassign_ioport(r->addr, r->size);
-                        }
-                    } else {
-                        cpu_register_physical_memory(pci_to_cpu_addr(r->addr),
-                                                     r->size,
-                                                     IO_MEM_UNASSIGNED);
-                        qemu_unregister_coalesced_mmio(r->addr, r->size);
-                    }
-                }
+                pci_unmap_region(d, r);
                 r->addr = new_addr;
                 if (r->addr != -1) {
                     r->map_func(d, i, r->addr, r->size, r->type);
diff --git a/hw/pci.h b/hw/pci.h
index 6da626b..4072f16 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -221,6 +221,9 @@ void pci_register_io_region(PCIDevice *pci_dev, int region_num,
                             uint32_t size, int type,
                             PCIMapIORegionFunc *map_func);
 
+void pci_resize_io_region(PCIDevice *pci_dev, int region_num,
+                          uint32_t size);
+
 int pci_add_capability(PCIDevice *pci_dev, uint8_t cap_id, uint8_t cap_size);
 
 void pci_del_capability(PCIDevice *pci_dev, uint8_t cap_id, uint8_t cap_size);
-- 
1.6.3.1.56.g79e1.dirty


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>,
	qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>,
	kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] [PATCH 08/11] qemu: add support for resizing regions
Date: Mon, 25 May 2009 15:26:05 +0300	[thread overview]
Message-ID: <20090525122605.GI5046@redhat.com> (raw)
In-Reply-To: <cover.1243253205.git.mst@redhat.com>

Make it possible to resize PCI regions.  This will be used by virtio
with MSI-X, where the region size depends on whether MSI-X is enabled,
and can change across load/save.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/pci.c |   54 ++++++++++++++++++++++++++++++++++++------------------
 hw/pci.h |    3 +++
 2 files changed, 39 insertions(+), 18 deletions(-)

diff --git a/hw/pci.c b/hw/pci.c
index 6bc3819..19905b9 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -392,6 +392,41 @@ void pci_register_io_region(PCIDevice *pci_dev, int region_num,
     *(uint32_t *)(pci_dev->mask + addr) = cpu_to_le32(mask);
 }
 
+static void pci_unmap_region(PCIDevice *d, PCIIORegion *r)
+{
+    if (r->addr == -1)
+        return;
+    if (r->type & PCI_ADDRESS_SPACE_IO) {
+        int class;
+        /* NOTE: specific hack for IDE in PC case:
+           only one byte must be mapped. */
+        class = pci_get_word(d->config + PCI_CLASS_DEVICE);
+        if (class == 0x0101 && r->size == 4) {
+            isa_unassign_ioport(r->addr + 2, 1);
+        } else {
+            isa_unassign_ioport(r->addr, r->size);
+        }
+    } else {
+        cpu_register_physical_memory(pci_to_cpu_addr(r->addr),
+                                     r->size,
+                                     IO_MEM_UNASSIGNED);
+        qemu_unregister_coalesced_mmio(r->addr, r->size);
+    }
+}
+
+void pci_resize_io_region(PCIDevice *pci_dev, int region_num,
+                          uint32_t size)
+{
+
+    PCIIORegion *r = &pci_dev->io_regions[region_num];
+    if (r->size == size)
+        return;
+    r->size = size;
+    pci_unmap_region(pci_dev, r);
+    r->addr = -1;
+    pci_update_mappings(pci_dev);
+}
+
 static void pci_update_mappings(PCIDevice *d)
 {
     PCIIORegion *r;
@@ -445,24 +480,7 @@ static void pci_update_mappings(PCIDevice *d)
             }
             /* now do the real mapping */
             if (new_addr != r->addr) {
-                if (r->addr != -1) {
-                    if (r->type & PCI_ADDRESS_SPACE_IO) {
-                        int class;
-                        /* NOTE: specific hack for IDE in PC case:
-                           only one byte must be mapped. */
-                        class = d->config[0x0a] | (d->config[0x0b] << 8);
-                        if (class == 0x0101 && r->size == 4) {
-                            isa_unassign_ioport(r->addr + 2, 1);
-                        } else {
-                            isa_unassign_ioport(r->addr, r->size);
-                        }
-                    } else {
-                        cpu_register_physical_memory(pci_to_cpu_addr(r->addr),
-                                                     r->size,
-                                                     IO_MEM_UNASSIGNED);
-                        qemu_unregister_coalesced_mmio(r->addr, r->size);
-                    }
-                }
+                pci_unmap_region(d, r);
                 r->addr = new_addr;
                 if (r->addr != -1) {
                     r->map_func(d, i, r->addr, r->size, r->type);
diff --git a/hw/pci.h b/hw/pci.h
index 6da626b..4072f16 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -221,6 +221,9 @@ void pci_register_io_region(PCIDevice *pci_dev, int region_num,
                             uint32_t size, int type,
                             PCIMapIORegionFunc *map_func);
 
+void pci_resize_io_region(PCIDevice *pci_dev, int region_num,
+                          uint32_t size);
+
 int pci_add_capability(PCIDevice *pci_dev, uint8_t cap_id, uint8_t cap_size);
 
 void pci_del_capability(PCIDevice *pci_dev, uint8_t cap_id, uint8_t cap_size);
-- 
1.6.3.1.56.g79e1.dirty

  parent reply	other threads:[~2009-05-25 12:29 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1243253205.git.mst@redhat.com>
2009-05-25 12:12 ` [PATCHv2] qemu: make default_write_config use mask table Michael S. Tsirkin
2009-05-25 12:12 ` Michael S. Tsirkin
2009-05-25 12:12   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:24 ` [PATCH 01/11] " Michael S. Tsirkin
2009-05-25 12:24 ` Michael S. Tsirkin
2009-05-25 12:24   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:25 ` [PATCH 02/11] qemu: capability bits in pci save/restore Michael S. Tsirkin
2009-05-25 12:25 ` Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:25 ` [PATCH 03/11] qemu: add routines to manage PCI capabilities Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-26  8:49   ` Isaku Yamahata
2009-05-26  8:49     ` Isaku Yamahata
2009-05-26  9:22     ` Michael S. Tsirkin
2009-05-26  9:22       ` Michael S. Tsirkin
2009-05-26  9:22     ` Michael S. Tsirkin
2009-05-26  8:49   ` Isaku Yamahata
2009-05-26  9:30   ` [PATCH] qemu: fix pci_find_capability for multiple caps Michael S. Tsirkin
2009-05-26  9:30     ` [Qemu-devel] " Michael S. Tsirkin
2009-05-26  9:30     ` Michael S. Tsirkin
2009-05-25 12:25 ` [PATCH 03/11] qemu: add routines to manage PCI capabilities Michael S. Tsirkin
2009-05-25 12:25 ` [PATCH 04/11] qemu: helper routines for pci access Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-26  2:33   ` Isaku Yamahata
2009-05-26  2:33     ` Isaku Yamahata
2009-05-26  6:41     ` Michael S. Tsirkin
2009-05-26  6:41     ` Michael S. Tsirkin
2009-05-26  6:41       ` Michael S. Tsirkin
2009-05-26  8:07       ` Avi Kivity
2009-05-26  8:07       ` Avi Kivity
2009-05-26  8:07         ` Avi Kivity
2009-05-26  8:49         ` Michael S. Tsirkin
2009-05-26  8:49         ` Michael S. Tsirkin
2009-05-26  8:49           ` Michael S. Tsirkin
2009-05-26  2:33   ` Isaku Yamahata
2009-05-25 12:25 ` Michael S. Tsirkin
2009-05-25 12:25 ` [PATCH 05/11] qemu: MSI-X support functions Michael S. Tsirkin
2009-05-25 12:25 ` Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-06-09 23:19   ` Paul Brook
2009-06-09 23:19     ` Paul Brook
2009-06-10  9:46     ` Michael S. Tsirkin
2009-06-10  9:46     ` Michael S. Tsirkin
2009-06-10  9:46       ` Michael S. Tsirkin
2009-06-10 14:07       ` Paul Brook
2009-06-10 14:07         ` Paul Brook
2009-06-10 14:25         ` Michael S. Tsirkin
2009-06-10 14:25           ` Michael S. Tsirkin
2009-06-10 14:39           ` Paul Brook
2009-06-10 14:39             ` Paul Brook
2009-06-10 14:47             ` Michael S. Tsirkin
2009-06-10 14:47               ` Michael S. Tsirkin
2009-06-10 15:15               ` Paul Brook
2009-06-10 15:15               ` Paul Brook
2009-06-10 15:15                 ` Paul Brook
2009-06-10 15:52                 ` Michael S. Tsirkin
2009-06-10 15:52                   ` Michael S. Tsirkin
2009-06-10 16:08                   ` Paul Brook
2009-06-10 16:08                     ` Paul Brook
2009-06-10 16:26                     ` Michael S. Tsirkin
2009-06-10 16:26                       ` Michael S. Tsirkin
2009-06-10 16:46                       ` Paul Brook
2009-06-10 16:46                         ` Paul Brook
2009-06-10 17:03                         ` Michael S. Tsirkin
2009-06-10 17:03                           ` Michael S. Tsirkin
2009-06-10 17:30                           ` Paul Brook
2009-06-10 17:30                             ` Paul Brook
2009-06-10 18:07                             ` Michael S. Tsirkin
2009-06-10 18:07                             ` Michael S. Tsirkin
2009-06-10 18:07                               ` Michael S. Tsirkin
2009-06-10 19:04                               ` Paul Brook
2009-06-10 19:04                                 ` Paul Brook
2009-06-11  8:29                                 ` Michael S. Tsirkin
2009-06-11  8:29                                 ` Michael S. Tsirkin
2009-06-11  8:29                                   ` Michael S. Tsirkin
2009-06-10 19:04                               ` Paul Brook
2009-06-10 17:30                           ` Paul Brook
2009-06-10 17:03                         ` Michael S. Tsirkin
2009-06-10 16:46                       ` Paul Brook
2009-06-10 16:26                     ` Michael S. Tsirkin
2009-06-10 16:08                   ` Paul Brook
2009-06-10 15:52                 ` Michael S. Tsirkin
2009-06-10 14:47             ` Michael S. Tsirkin
2009-06-10 14:39           ` Paul Brook
2009-06-10 14:25         ` Michael S. Tsirkin
2009-06-10 14:07       ` Paul Brook
2009-06-09 23:19   ` Paul Brook
2009-05-25 12:25 ` [PATCH 06/11] qemu: add flag to disable MSI-X by default Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:25 ` Michael S. Tsirkin
2009-05-25 12:25 ` [PATCH 07/11] qemu: minimal MSI/MSI-X implementation for PC Michael S. Tsirkin
2009-05-25 12:25 ` Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:26 ` [PATCH 08/11] qemu: add support for resizing regions Michael S. Tsirkin
2009-05-25 12:26 ` Michael S. Tsirkin [this message]
2009-05-25 12:26   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:26 ` [PATCH 09/11] qemu: virtio support for many interrupt vectors Michael S. Tsirkin
2009-05-25 12:26   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:26 ` Michael S. Tsirkin
2009-05-25 12:26 ` [PATCH 10/11] qemu: MSI-X support in virtio PCI Michael S. Tsirkin
2009-05-25 12:26 ` Michael S. Tsirkin
2009-05-25 12:26   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:26 ` [PATCH 11/11] qemu: request 3 vectors in virtio-net Michael S. Tsirkin
2009-05-25 12:26 ` Michael S. Tsirkin
2009-05-25 12:26   ` [Qemu-devel] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090525122605.GI5046@redhat.com \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=cotte@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.