From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Mel Gorman <mel@csn.ul.ie>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Yasunori Goto <y-goto@jp.fujitsu.com>
Subject: Re: [PATCH 1/3] clean up functions related to pages_min V2
Date: Tue, 26 May 2009 22:25:10 -0700 [thread overview]
Message-ID: <20090526222510.ad054b8a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090521092304.0eb3c4cb.minchan.kim@barrios-desktop>
On Thu, 21 May 2009 09:23:04 +0900 Minchan Kim <minchan.kim@gmail.com> wrote:
> Changelog since V1
> o Change function name from setup_per_zone_wmark_min to setup_per_zone_wmarks
> - by Mel Gorman advise
> o Modify description - by KOSAKI advise
>
> Mel changed zone->pages_[high/low/min] with zone->watermark array.
> So, the functions related to pages_min also have to be changed.
>
> * setup_per_zone_pages_min
> * init_per_zone_pages_min
>
> This patch is just clean up. so it doesn't affect behavior.
>
I cannot actually find a usable changelog amongst all that text. Can
you try again please?
afacit the patch simply changes the names of a couple of functions.
The changelog should concisely and completely describe what those naming
changes are, and the reason for making them.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Mel Gorman <mel@csn.ul.ie>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Yasunori Goto <y-goto@jp.fujitsu.com>
Subject: Re: [PATCH 1/3] clean up functions related to pages_min V2
Date: Tue, 26 May 2009 22:25:10 -0700 [thread overview]
Message-ID: <20090526222510.ad054b8a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090521092304.0eb3c4cb.minchan.kim@barrios-desktop>
On Thu, 21 May 2009 09:23:04 +0900 Minchan Kim <minchan.kim@gmail.com> wrote:
> Changelog since V1
> o Change function name from setup_per_zone_wmark_min to setup_per_zone_wmarks
> - by Mel Gorman advise
> o Modify description - by KOSAKI advise
>
> Mel changed zone->pages_[high/low/min] with zone->watermark array.
> So, the functions related to pages_min also have to be changed.
>
> * setup_per_zone_pages_min
> * init_per_zone_pages_min
>
> This patch is just clean up. so it doesn't affect behavior.
>
I cannot actually find a usable changelog amongst all that text. Can
you try again please?
afacit the patch simply changes the names of a couple of functions.
The changelog should concisely and completely describe what those naming
changes are, and the reason for making them.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-27 5:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 0:23 [PATCH 1/3] clean up functions related to pages_min V2 Minchan Kim
2009-05-21 0:23 ` Minchan Kim
2009-05-27 5:25 ` Andrew Morton [this message]
2009-05-27 5:25 ` Andrew Morton
2009-05-27 6:06 ` Minchan Kim
2009-05-27 6:06 ` Minchan Kim
2009-05-27 11:29 ` Minchan Kim
2009-05-27 11:29 ` Minchan Kim
2009-05-27 20:38 ` Andrew Morton
2009-05-27 20:38 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526222510.ad054b8a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.