From: Paul Mundt <lethal@linux-sh.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org, uclinux-dev@uclinux.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH 2/2] mtd/maps: uclinux: support Blackfin systems
Date: Wed, 27 May 2009 08:19:02 +0900 [thread overview]
Message-ID: <20090526231902.GA6295@linux-sh.org> (raw)
In-Reply-To: <8bd0f97a0905261024q178fbc80n4a997daca5a3b405@mail.gmail.com>
On Tue, May 26, 2009 at 01:24:46PM -0400, Mike Frysinger wrote:
> On Tue, May 26, 2009 at 13:06, Paul Mundt wrote:
> > Use the attached, and then just set uclinux_ram_map.phys = your_address_here
> > in your setup_arch(). Having weak symbols in drivers that are supposed to
> > be overriden by the architecture code is just way too backwards for
> > words. Globals suffice fine for this sort of thing, if you are not going
> > to go to the effort to pass this information to the driver directly that
> > is.
>
> i was thinking something else, but obviously this is nicer than what i
> was thinking
Unfortunately there is the problem that the map driver itself is a
tristate, so if this is built as a module, the symbol will not be
available to you. On the other hand, if it doesn't need to ever really be
a module, converting it to a bool ought to be workable. There are no
in-tree users that enable this as a module anyways.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
Greg Ungerer <gerg@uclinux.org>,
uclinux-dev@uclinux.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd/maps: uclinux: support Blackfin systems
Date: Wed, 27 May 2009 08:19:02 +0900 [thread overview]
Message-ID: <20090526231902.GA6295@linux-sh.org> (raw)
In-Reply-To: <8bd0f97a0905261024q178fbc80n4a997daca5a3b405@mail.gmail.com>
On Tue, May 26, 2009 at 01:24:46PM -0400, Mike Frysinger wrote:
> On Tue, May 26, 2009 at 13:06, Paul Mundt wrote:
> > Use the attached, and then just set uclinux_ram_map.phys = your_address_here
> > in your setup_arch(). Having weak symbols in drivers that are supposed to
> > be overriden by the architecture code is just way too backwards for
> > words. Globals suffice fine for this sort of thing, if you are not going
> > to go to the effort to pass this information to the driver directly that
> > is.
>
> i was thinking something else, but obviously this is nicer than what i
> was thinking
Unfortunately there is the problem that the map driver itself is a
tristate, so if this is built as a module, the symbol will not be
available to you. On the other hand, if it doesn't need to ever really be
a module, converting it to a bool ought to be workable. There are no
in-tree users that enable this as a module anyways.
next prev parent reply other threads:[~2009-05-26 23:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 9:46 [PATCH 1/2] mtd/maps: uclinux: fix building when partition support is disabled Mike Frysinger
2009-05-26 9:46 ` Mike Frysinger
2009-05-26 9:46 ` [PATCH 2/2] mtd/maps: uclinux: support Blackfin systems Mike Frysinger
2009-05-26 9:46 ` Mike Frysinger
2009-05-26 11:31 ` Paul Mundt
2009-05-26 11:31 ` Paul Mundt
2009-05-26 16:42 ` Mike Frysinger
2009-05-26 16:47 ` Paul Mundt
2009-05-26 16:47 ` Paul Mundt
2009-05-26 16:50 ` Mike Frysinger
2009-05-26 17:06 ` Paul Mundt
2009-05-26 17:06 ` Paul Mundt
2009-05-26 17:24 ` Mike Frysinger
2009-05-26 23:19 ` Paul Mundt [this message]
2009-05-26 23:19 ` Paul Mundt
2009-05-26 23:22 ` Mike Frysinger
2009-05-26 23:27 ` [uClinux-dev] " David McCullough
2009-05-26 23:33 ` [PATCH 1/3] mtd/maps: uclinux: allow systems to override map addr/size Mike Frysinger
2009-05-26 23:33 ` Mike Frysinger
2009-05-26 23:40 ` Paul Mundt
2009-05-26 23:40 ` Paul Mundt
2009-05-26 23:46 ` Paul Mundt
2009-05-26 23:46 ` Paul Mundt
2009-05-27 0:46 ` Mike Frysinger
2009-05-27 0:46 ` Mike Frysinger
2009-05-27 1:03 ` Paul Mundt
2009-05-27 1:03 ` Paul Mundt
2009-05-28 15:26 ` Artem Bityutskiy
2009-05-28 15:26 ` Artem Bityutskiy
2009-05-26 23:33 ` [PATCH 2/3] mtd/maps: uclinux: mark local stuff static Mike Frysinger
2009-05-26 23:33 ` Mike Frysinger
2009-06-10 1:47 ` Greg Ungerer
2009-06-10 1:47 ` Greg Ungerer
2009-05-26 23:33 ` [PATCH 3/3] mtd/maps: uclinux: do not allow to be built as a module Mike Frysinger
2009-05-26 23:33 ` Mike Frysinger
2009-06-10 2:34 ` [uClinux-dev] " Greg Ungerer
2009-06-10 2:34 ` Greg Ungerer
2009-06-10 1:46 ` [uClinux-dev] [PATCH 1/2] mtd/maps: uclinux: fix building when partition support is disabled Greg Ungerer
2009-06-10 1:46 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526231902.GA6295@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=uclinux-dev@uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.