From: Paul Mundt <lethal@linux-sh.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: uclinux-dist-devel@blackfin.uclinux.org, uclinux-dev@uclinux.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH 1/3] mtd/maps: uclinux: allow systems to override map addr/size
Date: Wed, 27 May 2009 10:03:59 +0900 [thread overview]
Message-ID: <20090527010359.GA8979@linux-sh.org> (raw)
In-Reply-To: <200905262047.21041.vapier@gentoo.org>
On Tue, May 26, 2009 at 08:46:24PM -0400, Mike Frysinger wrote:
> On Tuesday 26 May 2009 19:46:16 Paul Mundt wrote:
> > On Tue, May 26, 2009 at 07:33:16PM -0400, Mike Frysinger wrote:
> > > +extern char _ebss;
> > > +
> >
> > Also, it would be nice if the remaining architectures that define _ebss
> > could shove this in their asm/sections.h so we can kill this off from the
> > driver itself.
>
> well, everyone would still have to define the _ebss symbol otherwise they'd
> get an undefined error due to how the map is initialized.
Yes, but that is not the issue. The issue is that the section
extern has no place in a driver, this is precisely what asm/sections.h is
for. Only microblaze and sh define it there today, and there is already
inconsistency. Having the others define it for themselves and agreeing on
a type would permit us to kill it off from the driver.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
Greg Ungerer <gerg@uclinux.org>,
uclinux-dev@uclinux.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] mtd/maps: uclinux: allow systems to override map addr/size
Date: Wed, 27 May 2009 10:03:59 +0900 [thread overview]
Message-ID: <20090527010359.GA8979@linux-sh.org> (raw)
In-Reply-To: <200905262047.21041.vapier@gentoo.org>
On Tue, May 26, 2009 at 08:46:24PM -0400, Mike Frysinger wrote:
> On Tuesday 26 May 2009 19:46:16 Paul Mundt wrote:
> > On Tue, May 26, 2009 at 07:33:16PM -0400, Mike Frysinger wrote:
> > > +extern char _ebss;
> > > +
> >
> > Also, it would be nice if the remaining architectures that define _ebss
> > could shove this in their asm/sections.h so we can kill this off from the
> > driver itself.
>
> well, everyone would still have to define the _ebss symbol otherwise they'd
> get an undefined error due to how the map is initialized.
Yes, but that is not the issue. The issue is that the section
extern has no place in a driver, this is precisely what asm/sections.h is
for. Only microblaze and sh define it there today, and there is already
inconsistency. Having the others define it for themselves and agreeing on
a type would permit us to kill it off from the driver.
next prev parent reply other threads:[~2009-05-27 1:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 9:46 [PATCH 1/2] mtd/maps: uclinux: fix building when partition support is disabled Mike Frysinger
2009-05-26 9:46 ` Mike Frysinger
2009-05-26 9:46 ` [PATCH 2/2] mtd/maps: uclinux: support Blackfin systems Mike Frysinger
2009-05-26 9:46 ` Mike Frysinger
2009-05-26 11:31 ` Paul Mundt
2009-05-26 11:31 ` Paul Mundt
2009-05-26 16:42 ` Mike Frysinger
2009-05-26 16:47 ` Paul Mundt
2009-05-26 16:47 ` Paul Mundt
2009-05-26 16:50 ` Mike Frysinger
2009-05-26 17:06 ` Paul Mundt
2009-05-26 17:06 ` Paul Mundt
2009-05-26 17:24 ` Mike Frysinger
2009-05-26 23:19 ` Paul Mundt
2009-05-26 23:19 ` Paul Mundt
2009-05-26 23:22 ` Mike Frysinger
2009-05-26 23:27 ` [uClinux-dev] " David McCullough
2009-05-26 23:33 ` [PATCH 1/3] mtd/maps: uclinux: allow systems to override map addr/size Mike Frysinger
2009-05-26 23:33 ` Mike Frysinger
2009-05-26 23:40 ` Paul Mundt
2009-05-26 23:40 ` Paul Mundt
2009-05-26 23:46 ` Paul Mundt
2009-05-26 23:46 ` Paul Mundt
2009-05-27 0:46 ` Mike Frysinger
2009-05-27 0:46 ` Mike Frysinger
2009-05-27 1:03 ` Paul Mundt [this message]
2009-05-27 1:03 ` Paul Mundt
2009-05-28 15:26 ` Artem Bityutskiy
2009-05-28 15:26 ` Artem Bityutskiy
2009-05-26 23:33 ` [PATCH 2/3] mtd/maps: uclinux: mark local stuff static Mike Frysinger
2009-05-26 23:33 ` Mike Frysinger
2009-06-10 1:47 ` Greg Ungerer
2009-06-10 1:47 ` Greg Ungerer
2009-05-26 23:33 ` [PATCH 3/3] mtd/maps: uclinux: do not allow to be built as a module Mike Frysinger
2009-05-26 23:33 ` Mike Frysinger
2009-06-10 2:34 ` [uClinux-dev] " Greg Ungerer
2009-06-10 2:34 ` Greg Ungerer
2009-06-10 1:46 ` [uClinux-dev] [PATCH 1/2] mtd/maps: uclinux: fix building when partition support is disabled Greg Ungerer
2009-06-10 1:46 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090527010359.GA8979@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=uclinux-dev@uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.