Re: [benchmark] 1% performance overhead of paravirt_ops on native kernels

[Dave McCracken <dcm@mccr.org>]

On Thursday 04 June 2009, Linus Torvalds wrote:
> On Thu, 4 Jun 2009, Rusty Russell wrote:
> > > Turn off HIGHMEM64G, please (and HIGHMEM4G too, for that matter - you
> > > can't compare it to a no-highmem case).
> >
> > Thanks, your point is demonstrated below.  I don't think HIGHMEM4G is
> > unreasonable for a distro tho, so I turned that on instead.
>
> Well, I agree that HIGHMEM4G is a reasonable thing to turn on.
>
> The thing I disagree with is that it's at all valid to then compare to
> some all-software feature thing. HIGHMEM doesn't expand any esoteric
> capability that some people might use - it's about regular RAM for regular
> users.

I think you're missing the point of Rusty's benchmark.  I see his exercise as 
"compare a kernel configured as a distro would vs a custom-built kernel 
configured for the exact target environment".  In that light, questions about 
the CONFIG options Rusty used should be based on whether most distros would 
use them in their stock kernels as opposed to how necessary they are.

What I see as the message of his benchmark is if you care about performance 
you should be customizing your kernel anyway.  Distro kernels are slow.  An 
option that makes the distro kernel a bit slower is no big deal since anyone 
who wants speed should already be rebuilding their kernel.

Don't get me wrong.  I think it's always a good idea to minimize any 
performance penalty, even under specific configurations.  I just think 
criticizing it because distros might enable it is a poor argument.

Dave McCracken
Oracle Corp.